Add Rust-style dyn vtables
#33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to redo the vtable work in #26 that I wound up rolling back. In the new approach, we have:
best::dyn<Interface>is a special type for putting in abest::ptrand friends, which emulates Rust'sdyn Trait.best::interfacedefines what can go in abest::dyn, which is essentially a type that provides abest::vtableplus an untyped pointer. It is expected, but not required, that this type provide helper functions that emulate calling virtual functions. TheBEST_INTERFACEmacro makes it "easy" to define these.BEST_INTERFACE, I've addedmacro.hwhich contains all of the usual very evil macro-writing-macros.best::fnrefnow exposesbest::fnref::fnptr, which makes it easy to convert between the member function signature (which lacks athispointer) and the equivalent with avoid* thisargument.best::dynptrandbest::dynboxare convenience aliases for working with dyns.best::boxnow supportsbest::try_copy, which is needed becausebest::interfacescannot guarantee copying at the moment.