esm exhausted all local ports #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix can't assign requested address
fix can't assign requested address
fix can't assign requested address
bool default no more needed
Add "fields" parameter to output specified field.
Add "fields" parameter to output specified field.
Add "fields" parameter to output specified field.
Add "fields" parameter to output specified field.
Add "fields" parameter to output specified field.
medcl
reviewed
Apr 25, 2018
domain.go
Outdated
| ScrollTime string `short:"t" long:"time" description:"scroll time" default:"1m"` | ||
| ScrollSliceSize int `long:"sliced_scroll_size" description:"size of sliced scroll, to make it work, the size should be > 1" default:"1"` | ||
| RecreateIndex bool `short:"f" long:"force" description:"delete destination index before copying" default:"false"` | ||
| RecreateIndex bool `short:"f" long:"force" description:"delete destination index before copying" ` |
There was a problem hiding this comment.
can you keep this default to false, same below
There was a problem hiding this comment.
Hi, the code of packge go-flags had been changed, boolean flag always default to `false' .
https://github.com/jessevdk/go-flags/blob/master/group.go
if option.isBool() && option.Default != nil {
return newErrorf(ErrInvalidTag,
"boolean flag `%s' may not have default values, they always default to `false' and can only be turned on",
option.shortAndLongName())
}
prefer to safe default
fix header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running esm, it would exhaust all the local ports.
How to repeat：
Set parameter
-cto 1，run esm, after 10 minutes, usenetstatcommand to check the local established connections.After a while, esm raised lots of errors.
This is because, the default HTTP client's Transport does not attempt to reuse HTTP/1.0 or HTTP/1.1 TCP connections ("keep-alive") unless the Body is read to completion and is closed. And the code just calls
resp.Body.Close()and the body isn't cleared.This paper has details about the problem.