Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sahibkhokhar
Copy link
Collaborator

@sahibkhokhar sahibkhokhar commented Jan 20, 2025

TL;DR

Added configuration file support for Zoom bot settings and improved meeting join process

What changed?

  • Introduced config.json for managing meeting credentials and bot display name
  • Removed hardcoded Zoom URL and meeting parameters
  • Added validation for meeting ID, password, and display name from config
  • Simplified URL construction by removing the URL parser function
  • Updated Dockerfile to copy the new config.json file

How to test?

  1. Create a config.json file with the following structure:
{
  "meeting_info": {
    "meeting_id": "your_meeting_id",
    "meeting_password": "your_meeting_password"
  },
  "bot_display_name": "your_bot_name"
}
  1. Run the container and verify the bot joins the meeting with the configured display name
  2. Confirm the recording is still properly saved and uploaded to S3

Why make this change?

To improve maintainability and security by moving meeting credentials out of the source code and into a configuration file, making it easier to update meeting parameters without code changes

Completes MEE-102

Copy link
Collaborator Author

sahibkhokhar commented Jan 20, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sahibkhokhar sahibkhokhar marked this pull request as ready for review January 20, 2025 22:03
@sahibkhokhar sahibkhokhar force-pushed the 01-20-feat_integrate_config.json_with_zoom_bot branch from 48e10f9 to 3a8f746 Compare January 20, 2025 22:04
@graphite-app
Copy link

graphite-app bot commented Jan 20, 2025

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (01/20/25)

1 assignee was added to this PR based on Jason Huang's automation.

@sahibkhokhar sahibkhokhar changed the base branch from 01-20-fix_updates_button_clicks_for_joining_zoom_meeting to graphite-base/86 January 23, 2025 15:17
@sahibkhokhar sahibkhokhar force-pushed the 01-20-feat_integrate_config.json_with_zoom_bot branch from 3a8f746 to a9362ad Compare January 23, 2025 15:17
@sahibkhokhar sahibkhokhar changed the base branch from graphite-base/86 to main January 23, 2025 15:18
@sahibkhokhar sahibkhokhar force-pushed the 01-20-feat_integrate_config.json_with_zoom_bot branch from a9362ad to f45ae24 Compare January 23, 2025 15:18
@sahibkhokhar sahibkhokhar merged commit fee7692 into main Jan 23, 2025
3 checks passed
Copy link
Collaborator Author

Merge activity

  • Jan 23, 10:18 AM EST: A user merged this pull request with Graphite.

@sahibkhokhar sahibkhokhar deleted the 01-20-feat_integrate_config.json_with_zoom_bot branch January 23, 2025 15:18
liongyeehong pushed a commit to Xxell-Ai/meetingbot that referenced this pull request Sep 15, 2025
### TL;DR
Added configuration file support for Zoom bot settings and improved meeting join process

### What changed?
- Introduced `config.json` for managing meeting credentials and bot display name
- Removed hardcoded Zoom URL and meeting parameters
- Added validation for meeting ID, password, and display name from config
- Simplified URL construction by removing the URL parser function
- Updated Dockerfile to copy the new config.json file

### How to test?
1. Create a `config.json` file with the following structure:
```json
{
  "meeting_info": {
    "meeting_id": "your_meeting_id",
    "meeting_password": "your_meeting_password"
  },
  "bot_display_name": "your_bot_name"
}
```
2. Run the container and verify the bot joins the meeting with the configured display name
3. Confirm the recording is still properly saved and uploaded to S3

### Why make this change?
To improve maintainability and security by moving meeting credentials out of the source code and into a configuration file, making it easier to update meeting parameters without code changes

Completes MEE-102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants