Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@nymkappa
Copy link
Member

@nymkappa nymkappa commented Nov 14, 2024

Fixes #5639

Currently we always show a generic message if we fail to accelerate a tx, regardless of the reason. However the frontend knows if it's a payment issue or not, therefore I display the Square payment error when appropriate instead of the generic message.

Screenshot 2024-11-14 at 16 42 14

@nymkappa nymkappa requested a review from wiz November 14, 2024 15:44
@cla-bot cla-bot bot added the cla-signed label Nov 14, 2024
@nymkappa nymkappa force-pushed the nymkappa/square-errors branch from 9d28b40 to 72ddb8c Compare November 14, 2024 15:46
Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nymkappa nymkappa merged commit e01898a into master Jan 20, 2025
14 checks passed
@nymkappa nymkappa deleted the nymkappa/square-errors branch January 20, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[accelerator] display square payment error properly instead of generic "something went wrong"

3 participants