Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@takuo
Copy link

@takuo takuo commented Oct 3, 2011

  • specify error type 'LoadError' for rescue.

 - specify error type 'LoadError' for rescue.
@ngollan
Copy link
Member

ngollan commented Oct 3, 2011

Thanks for the fix; however, the methopara gem itself only provided functionality that made its way into the core library with 1.9.2 and we don't really support 1.9.1, so the right fix would be to remove the methopara gem requirement entirely.

Could you please check if merb-action-args from the active_support branch still works for you? It should do things "right" in that regard already.

@takuo
Copy link
Author

takuo commented Oct 3, 2011

Yes. I think so too.
And the active_support branch works for me :-)
So, could you please remove the 'require' from 1.1.x branch if you have plan to release 1.1.4.

Thanks.

@ngollan
Copy link
Member

ngollan commented Oct 3, 2011

I don't really have that plan. Keeping the 1.1 branch up to date would be too much, seeing how I didn't even get to squeeze in some work on my pet branch, and it doesn't play nice with anything current really.

action-args is an issue in itself since it doesn't work consistently on anything but 1.8.7 MRI and JRuby (see the Google group for that); it might be viable again with Ruby 2.0.

If you want to, you can post a pull request that ports the new stuff from the AS branch back to 1.1 (it really shouldn't even use AS functionality) which I would love to accept, but all in all you're probably better off not using it at all when running under 1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants