Don't attempt to parse a file if the key already exists in the metadata, even if the file is missing #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and the file hasn't been explicitly passed to you. This prevents errors when working with watch() or browserSync() plugins, since those generally only pass a subset of the source directory through an existing metalsmith object.
Contributor
Author
|
This might also solve the issue that #4 was targeting, since that PR doesn't make a lot of sense outside of the context of a partial listing of files being passed through |
Contributor
Author
|
Not to be a pest, @ianstormtaylor, but is this plugin even accepting PRs? |
|
Thanks @deltamualpha! This PR makes metalsmith-metadata compatible with metalsmith-watch (otherwise, it just throws errors at each change). |
|
Too bad it hasn't been merged until now. Please @ianstormtaylor or @lambtron merge that ! |
lambtron
added a commit
that referenced
this pull request
Nov 15, 2015
Don't attempt to parse a file if the key already exists in the metadata, even if the file is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using metalsmith-metadata with watchers like watch() or browserSync() that perform partial rebuilds of content, the plugin throws errors because the json/yaml files it's looking for aren't part of the partial bundle of files. However, in these cases, we're generally ok, because the work has already been done and the key exists in the metadata already.
This pull request makes it so the plugin passes safely in this case, while still parsing and proceeding with overwriting an existing key if the json/yaml file in question is in the file list passed to it. It also adds tests for this behavior.