-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Accounts UI CSS upgrade #13840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-3.4
Are you sure you want to change the base?
Accounts UI CSS upgrade #13840
Conversation
Had AI look at meteor.com and adopt some of the styling into look.
β Deploy Preview for v3-meteor-api-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
β Deploy Preview for v3-migration-docs canceled.
|
|
We need to discuss the location of the CSS. Right now it is in the |
|
@italojs v3.3.1? Probably not a bad choice that I think about it. This might be a sexy things to have on the changelog to draw people in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you have changes on the blaze git submodule? It shouldn't have changes there, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just update to the latest version
|
@StorytellerCZ i'm sorry, what do you mean? it will be in the change logs anyway |
|
3.3.1 is a fine for release. |
|
Iβm not sure this belongs in a patch. If Iβm right, it introduces visual breaking changes for production apps. All developers using the current Accounts UI would suddenly see styling updates in a patch. This needs its own breakingβchange or migration notes. Iβd prefer to include and announce it in Meteor 3.4. |
|
@nachocodoner I agree. That is why I was surprised when @italojs targeted the 3.3.1 branch. Moved everything to 3.4.0 branch target. |
|
I'm keeping an eye on this PR for a later Meteor 3.4 beta, since it includes an UI breaking change. Together with another update on my side that could cause some issues (though no breaking changes expected), I prefer to include them in a later round of 3.4 beta releases. |
I went ahead and upgraded the CSS for Accounts UI.
Changes:
New look: