Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@StorytellerCZ
Copy link
Collaborator

I went ahead and upgraded the CSS for Accounts UI.

Changes:

  • Dropped IE8 and other ancient workarounds
  • Removed LESS, now just pure CSS
  • Detect dark theme
  • Using CSS variables to allow users to override the look
  • Detects dark theme and automatically applies it
  • Updated the look to follow a bit more closer with meteor.com

New look:

image

@netlify
Copy link

netlify bot commented Jul 7, 2025

βœ… Deploy Preview for v3-meteor-api-docs ready!

Name Link
πŸ”¨ Latest commit 363403f
πŸ” Latest deploy log https://app.netlify.com/projects/v3-meteor-api-docs/deploys/686bfac4436e000008ad39c6
😎 Deploy Preview https://deploy-preview-13840.docs.meteor.com
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jul 7, 2025

βœ… Deploy Preview for v3-migration-docs canceled.

Name Link
πŸ”¨ Latest commit 363403f
πŸ” Latest deploy log https://app.netlify.com/projects/v3-migration-docs/deploys/686bfac4486f340008e9905d

@StorytellerCZ StorytellerCZ added this to the Release 3.4 milestone Jul 7, 2025
@italojs italojs changed the base branch from devel to release-3.3.1 July 7, 2025 16:52
@StorytellerCZ
Copy link
Collaborator Author

We need to discuss the location of the CSS. Right now it is in the accounts-ui-unstyled and then imported only if accounts-ui is present. Honestly it makes no sense to me and I would like to move it to accounts-ui (after testing that it still works as intended).

@StorytellerCZ StorytellerCZ requested review from Grubba27 and italojs July 7, 2025 19:33
@StorytellerCZ
Copy link
Collaborator Author

@italojs v3.3.1? Probably not a bad choice that I think about it. This might be a sexy things to have on the changelog to draw people in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have changes on the blaze git submodule? It shouldn't have changes there, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update to the latest version

@italojs
Copy link
Member

italojs commented Jul 14, 2025

@StorytellerCZ i'm sorry, what do you mean? it will be in the change logs anyway
but if you prefer, we could move it for release 3.4, but it will take a while to be published

@StorytellerCZ
Copy link
Collaborator Author

3.3.1 is a fine for release.

@nachocodoner
Copy link
Member

I’m not sure this belongs in a patch. If I’m right, it introduces visual breaking changes for production apps. All developers using the current Accounts UI would suddenly see styling updates in a patch. This needs its own breaking‐change or migration notes. I’d prefer to include and announce it in Meteor 3.4.

@StorytellerCZ StorytellerCZ changed the base branch from release-3.3.1 to release-3.4.0 July 16, 2025 08:03
@StorytellerCZ
Copy link
Collaborator Author

@nachocodoner I agree. That is why I was surprised when @italojs targeted the 3.3.1 branch. Moved everything to 3.4.0 branch target.

@italojs italojs changed the base branch from release-3.4.0 to release-3.4 July 16, 2025 22:46
@nachocodoner
Copy link
Member

I'm keeping an eye on this PR for a later Meteor 3.4 beta, since it includes an UI breaking change. Together with another update on my side that could cause some issues (though no breaking changes expected), I prefer to include them in a later round of 3.4 beta releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants