Pretty Server Error #13848
Pretty Server Error #13848
Conversation
Upgraded the look of the server error page. This has been a longstanding TODO there. It also now links to docs, guide and forums to find help.
✅ Deploy Preview for v3-meteor-api-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
That looks insanely good! Thanks a lot for your work here @StorytellerCZ I'll move to 3.4 so that we can do some content around this change(people should see how polished Meteor is) In 3.3.1 we plan on only fixing issues consequently our updates in the forums and in youtube will be shorter But for 3.4 we plan to do a more planned release, where I think having this change as an item in the highlight would be nice |
|
I've run into this opportunity while trying to fix another issue. I think there is a few more opportunities like this. |
|
This looks great! Thoughts on adding https://highlightjs.org/ to make the log output a little prettier? ❤️ |
|
@wreiske not really, I just came quickly across this so I haven't thought of those. I will look into it. |
|
@italojs @nachocodoner since this branch originally targeted 3.3.1 there is a lot of extra commits here as 3.4 does not have the changes from that branch yet. |
|
@StorytellerCZ We will release 3.3.1 soon, then we can do a rebase for this branch. In the last case, we can do a cherry pick, but I hope it's not necessary after merging 3.3.1 into devel. |
|
I'm about to review the PRs for the upcoming Meteor 3.4 releases listed at https://github.com/meteor/meteor/milestone/122 They will be included in 3.4 only if they pass all PR checks. Getting them green soon could allow a beta release earlier. This change seems to still fail a test. |
|
Given that this is based on |
|
Release 3.4 branch was green, but it might turn red again as I merge some contributions (it shouldn't though as they were green). This PR was failing before, so let’s wait for the release 3.4 branch to be stable first, and then I’ll retry here. |
Upgraded the look of the server error page.
This has been a longstanding TODO there.
It also now links to docs, guide and forums to find help.
New look takes into account the browser theme settings:
