forked from web-platform-tests/wpt
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] master from web-platform-tests:master #2164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
10,000
commits into
meunice:master
Choose a base branch
from
web-platform-tests:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the contents of some tests were updated to reflect the spec defined behavior of dense-packing always placing items into the highest, start-most track opening, the descriptions of the test were not all properly updated. This CL fixes the descriptions for the fixed tests. The description that describes prioritizing the track openings in the start-most track can be found in step 4 of the Grid-Lanes (Masonry) Layout Algorithm: https://drafts.csswg.org/css-grid-3/#masonry-layout-algorithm. Bug: 343257585 Change-Id: Ib49d2a5aef401576ddd5a75242a442e8b46baebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7234016 Commit-Queue: Celeste Pan <[email protected]> Reviewed-by: Kurt Catti-Schmidt <[email protected]> Cr-Commit-Position: refs/heads/main@{#1555807}
This change uses the new attribute that informs focusgroup which element should have initial focus when entering, either when `no-memory` is present, or when entering the focusgroup for the first time. See github issue and section in the explainer: * openui/open-ui#1314 * https://open-ui.org/components/scoped-focusgroup.explainer/#entry-priority-control Relatedly, with this change, focusgroup no longer considers elements that are not keyboard focusable (tabindex=-1) to be participating in the focusgroup, necessitating test updates. Tests for tabindex priority and direction removed because tabindex is no longer considered when determining entry elements. Only memory and focusgroup-entry-priority attribute matter now. Bug: 4021071 Change-Id: I300808592a573faccacfa8421d885d48e7013e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7164517 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Jacques Newman <[email protected]> Cr-Commit-Position: refs/heads/main@{#1555844}
Updates focus_controller to use the new utils for focusgroup. Since each focusgroup segment is guaranteed to have just a single tab stop, this means that focusgroup effectively removes all other elements from sequential focus navigation. This change updates the focus algorithm to not consider these elements when seeking to find the next focusable item. Bug: 4021071 Change-Id: I05d355b1161b2b89ef23f50b31c1e60100893ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7200224 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Jacques Newman <[email protected]> Cr-Commit-Position: refs/heads/main@{#1555866}
Bug: 458113204 Change-Id: Iba2c3fa60f27d01ea28f7d10063c7e70d04dcfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7125591 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1555870}
#56586) * Fix ref link for background-clip: border-area test * Add missing reference for background-clip: border-area test
This test exercises a few problematic situations I encountered when testing the bloom filter implementation over a large number of websites, mostly centered around class value matching which we cannot utilize the bloom filter for. Differential Revision: https://phabricator.services.mozilla.com/D273068 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1997380 gecko-commit: 90830cf67446d75a8c0b6e058a18b67a35238fc8 gecko-reviewers: emilio
Testing whether or not unpartitioned storages are accessible via the handle doesn't actually rely on cookie accessibility in most cases, so we should remove the assertions about cookies from those test cases. Secondly, MaybeSetStorageAccess is a no-op in all browsers now (except content_shell), so we should avoid it if possible. Change-Id: I9a1a40697637805017f231277d8b27d7f687e9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7239169 Commit-Queue: Chris Fredrickson <[email protected]> Reviewed-by: Ari Chivukula <[email protected]> Cr-Commit-Position: refs/heads/main@{#1556091}
…ntainingBlock(). Assume an ib-split `-moz-block-inside-inline-wrapper` is split by a column-span. The wrapper **before** column-span might not be an absolute containing block if it does not have any abspos children. In that case, `nsIFrame::Init()` won't create an absolute containing block for the wrapper continuation **after** the column-span. This patch removes the assertions and properly sets up an absolute containing block for the continuation when it needs one. Differential Revision: https://phabricator.services.mozilla.com/D275275 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2004166 gecko-commit: cf4ea2cf0c475ac4a7d199f0918babac20d5f674 gecko-reviewers: dholbert, layout-reviewers
Includes: - Fix bug where a new channel can be prematurely removed from mChannels due to the closing of a previous channel with the same id. - Do not transition to open until our open request gets an ack. - Simplify SendDataMessage a bit. Differential Revision: https://phabricator.services.mozilla.com/D272355 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1999831 gecko-commit: 32d43146de753adf6200c636813dce628ffe448d gecko-reviewers: ng
Browsers currently differ in how they preserve array order for CSSMathSum and CSSMathProduct. This patch adds a new helper, `assert_style_value_array_unordered_equals()`, to compare values while ignoring their order. This is a temporary relaxation until the spec is clarified and tests can assert canonical (sorted) ordering. Differential Revision: https://phabricator.services.mozilla.com/D271038 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1990419 gecko-commit: 3ad7cd633537b56bb0ef46b29614120bf5444781 gecko-reviewers: emilio
I think this test is redundant with the coverage in webmessaging/broadcastchannel and storage-access-api/storage-access-beyond-cookies.BroadcastChannel.sub.https.window.js. Change-Id: Ifc4b4bb204fd089609e1615d1be7838e308703e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7239750 Reviewed-by: David Baron <[email protected]> Reviewed-by: Ari Chivukula <[email protected]> Commit-Queue: Chris Fredrickson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1556124}
Bug: 390314945, 466134208 Change-Id: Ib1045aad44d9fe20930fc8b1c0663bcbcbb37e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7222830 Reviewed-by: David Awogbemila <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/main@{#1556161}
This is basically streamAppendHTMLUnsafe + RemoveChildren. Bug: 431374376 Change-Id: Ic6a8a755dbed60889b6870cc624a0719a4976f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7242324 Reviewed-by: Philip Jägenstedt <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1556213}
This CL revies the practice of computing the maximum bounds of a cc clip path animation, which was originally removed to allow for clip-path: none values in animation. The maximum bounds of the animation, like before, is calculated as the union of all keyframes (accounting for timing function extrapolation). Clip-path: none is handled by using the paint cull rect, which is assumed to be large enough to contain all the content that could potentially be clipped by the animation, except in the case of composited transform animations, where we fall back to main. This is done because the performance of having unbounded mask images was extremely poor, with excessive tile creation causing large memory usage on the compositor, and very slow rasterization times in viz. Bug: 447935064, 449779020 Change-Id: Id73d96fc7b16c0333c79343eb3c965aba0473e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7161176 Reviewed-by: Kevin Ellis <[email protected]> Reviewed-by: Stefan Zager <[email protected]> Commit-Queue: Claire Chambers <[email protected]> Cr-Commit-Position: refs/heads/main@{#1556237}
This reverts commit df686d944283cfbb801057be0c8134c3e0c3f674. The previous attempt had a flaky test which has been removed this time around. Bug: 425579196, 408010435 Change-Id: I6f0563e0c04197a792b2cee6efe1535de432cc17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7235545 Reviewed-by: Robert Flack <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1556246}
Verifies that `pointerdown`/`keydown` event timing entries can have their durations set before the matching `*up` event is fired. Original patch was modified to resolve a potential race in browsers in which `await afterNextPaint()` does not guarantee the dispatch of event timing entries. To make sure the pointerdown/keydown's event timing entry had its duration set, we now produce an interleaving event and await until its event timing entry is observed. This ensures that the "Dispatch pending Event Timing entries" step ran.
…exception Bug: 462010740 Change-Id: I72c374f04feb023c5749ca5f9ddedbf58358aff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7239868 Reviewed-by: Nate Chapin <[email protected]> Commit-Queue: Andrey Kosyakov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1556255}
This CL implements fragmentation logic for gap segments states. Gap segments states control the rule breaking and visibility functionality for gap decorations. In order for these ranges to be valid in fragmentation context, some changes had to be made with the guiding principle that during fragmentation main(row) gaps are mostly affected/shifted. The changes are: (1) A `MainGap` copy-esque constructor is introduced such that we can use the constructed ranges from the unfragmented main gap and just update the offset. (2) Adjustment functions are added for the ranges of cross gaps such that those ranges are fragmentation-aware and updated to be relative to the current fragment. Tests have been added to exercise this change. Bug: 357648037 Change-Id: Id75b924210c84ad26fe9cef36112829e502b8275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056842 Commit-Queue: Sam Davis Omekara <[email protected]> Reviewed-by: Alison Maher <[email protected]> Cr-Commit-Position: refs/heads/main@{#1556284}
Bug: 40321528 Change-Id: I541cf27b603c00b05cd8fe8b9aa4b3249189a227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7235295 Auto-Submit: Kent Tamura <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1556395}
This patch ensures the toggle event is dispatched for the details element after the document load finishes. I suspect this test was timing out because the toggle event was fired before the document loaded when running in headless mode, which resulted in ReferenceError for child elements (`a` or `b`). Bug: 465614980 Change-Id: Ia52e63939d0f59cee6088d849d459a09feb81bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7237758 Commit-Queue: Ashish Kumar <[email protected]> Reviewed-by: Rohan Raja <[email protected]> Reviewed-by: Kent Tamura <[email protected]> Cr-Commit-Position: refs/heads/main@{#1556530}
…mDoc data (#56352) * Digital Credentials: implement CANONICAL_REQUEST_OBJECTS with actual mDoc data - Add CANONICAL_REQUEST_OBJECTS with real mDoc deviceRequest and encryptionInfo data - Update factory functions to use canonical objects as defaults with data spread - Refactor internal architecture with new buildRequests and makeOptionsInternal helpers - Make mediation optional in type definitions (no longer defaults to 'required') - Add comprehensive data parameter support to config interfaces - Complete property bag + signal + protocol selection + canonical objects integration * Digital Credentials: Simplify helper function architecture and add requests parameter - Add requests parameter to MakeGetOptionsConfig and MakeCreateOptionsConfig interfaces - Replace complex makeOptionsUnified/makeOptionsInternal system with simpler makeCredentialOptionsFromConfig - Convert buildRequestsFromProtocols to functional programming approach using .map() - Remove factory functions (makeOID4VPDict, makeMDocRequest) in favor of inline functions in allMappings - Make mediation optional in CredentialRequestOptions and CredentialCreationOptions - Enhance TypeScript annotations with generics for better type safety - Support empty protocol arrays (protocol: []) for testing scenarios - Clean up unused imports and improve documentation alignment * Add data parameter to config interfaces and update tests to use clean data override pattern - Add data parameter to MakeGetOptionsConfig and MakeCreateOptionsConfig for overriding canonical data - Wire explicitData parameter through buildRequestsFromProtocols call chain properly - Update tests to use clean makeGetOptions({data}) pattern instead of manual object construction - Replace post-construction data manipulation with clean data override during construction - Maintain separation of concerns: protocol selection automatic, data override optional
…to the BiDi client. Differential Revision: https://phabricator.services.mozilla.com/D275230 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1944568 gecko-commit: 38c56db844043d8ee13479d6172df52ff69d5d86 gecko-reviewers: jgraham, jdescottes
…ions. Differential Revision: https://phabricator.services.mozilla.com/D275231 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1944568 gecko-commit: e8757a81c14893a58dd6f294ddc725e56e28d418 gecko-reviewers: jdescottes
I don't think we need to check the another default paragraph mode since it's too tricky case. Differential Revision: https://phabricator.services.mozilla.com/D277259 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2007052 gecko-commit: 3980182d538140a6ff3dff1930eef5d9762b23f2 gecko-reviewers: m_kato
Differential Revision: https://phabricator.services.mozilla.com/D277260 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2007052 gecko-commit: 01da6c97a53a609443514a1de2b5a44c9899ccdb gecko-reviewers: m_kato
….html` to WPT Note that the `inputType` values are tested in `input-events/input-events-exec-command.html`. Differential Revision: https://phabricator.services.mozilla.com/D277261 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2007052 gecko-commit: 9657f78c1ff89cbcf491c4632ccca7cd5f524d31 gecko-reviewers: m_kato
Differential Revision: https://phabricator.services.mozilla.com/D277262 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2007052 gecko-commit: 27fe036ece8a0299ed4b723e99a9e0cc21290d4b gecko-reviewers: m_kato
During editing operations (e.g., typing or inserting newlines), layout changes can occur that scroll anchoring misinterprets as unwanted shifts. This causes the browser to incorrectly "adjust" the scroll position, leading to unexpected jumps. This CL fixes this by using `SuppressScrollAnchorScope` within `TypingCommand`. This explicitly disables scroll anchoring logic while the editing command is being applied, ensuring the viewport remains stable during user input. Bug: 41477953, 4090335 Change-Id: If80660df45c563ecf1d91c6d9163000753417e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7279282 Reviewed-by: Steve Kobes <[email protected]> Commit-Queue: Peng Zhou <[email protected]> Cr-Commit-Position: refs/heads/main@{#1562502}
This makes significant changes to RelatedAccIterator, nsLabelsNodeList and nsContentList: - RelatedAccIterator now eagerly constructs a TreeOrderedArray of related elements, walking up shadow roots from mDependentContent while the shadow root's reference target is either mDependentContent or a host of one of its ancestor shadow roots. - nsLabelsNodeList now has an array of roots as well as mRootNode in the superclass nsContentList. This list is reset under certain conditions, adding each shadow root found by walking up from the labeled element until one is found which doesn't have either the labeled element or the host of one of its ancestor shadow roots as a reference target. The last element in this list is set as mRootNode in the superclass, and is either the containing document, or the subtree root of either the labeled element or the host element whose containing shadow root doesn't have it as a reference target. Each root has a mutation observer added to ensure that the list is marked dirty when necessary, and also that roots are removed from `mRoots` when they are destroyed. - In order to enable nsLabelsNodeList to be a mutation observer for each root, nsContentList now inherits from nsStubMultiMutationObserver instead of nsStubMutationObserver. This change also moves the ReferenceTargetChangeObserver-related methods from DocumentOrShadowRoot on to Element, and the related data structures on to nsExtendedDOMSlots. It also introduces a distinction between GetControlForBindings, which returns an element in the same scope as the label element it's called on, and GetLabeledElementInternal, which returns the element which actually has the label element as its label. Differential Revision: https://phabricator.services.mozilla.com/D261368 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1981349 gecko-commit: c74f11c985e8982c5622f61717fce8bcfa6d6aa5 gecko-reviewers: credential-management-reviewers, webidl, dimi, Jamie, smaug
…44, Bug 1983766, Bug 1989323 - Add referenceTarget support for label/for, label wrapped and output/for. " for causing android build bustages. This reverts commit 1b5cf4cdf8e443dc9ada5c3ee53b06c2a1c4b678. Revert "Bug 1981346 - Add referenceTarget support for the form attribute. r=credential-management-reviewers,webidl,dimi,Jamie,smaug" This reverts commit 2394d9205a7a0b5baed751d875c023dd047487f9. Revert "Bug 1981345 - Implement referenceTarget support for multiple element attributes. r=dom-core,Jamie,smaug" This reverts commit 571a17ff820b6a34d72b69b9ae5752020b193d74. Revert "Bug 1984685 - Refactor: consistently return Maybe<nsTArray<RefPtr<Element>>> when getting attr-associated elements, and key AttrRelProviders on nsAtom rather than nsString. r=dom-core,morgan,Jamie,smaug" This reverts commit 3b389fdd62e93b624a2a01b240e30556c059f389. Revert "Bug 1981344 - Implement referenceTarget support for single-element attributes. r=dom-core,credential-management-reviewers,webidl,layout-reviewers,emilio,keithamus,smaug,mtigley" This reverts commit 5cc2a12756a9de2d4352f28ce12744dad66b15f0. Revert "Bug 1983766 - Split single element attribute getters into bindings/internals versions. r=dom-core,credential-management-reviewers,webidl,layout-reviewers,smaug,keithamus,jwatt,mtigley" This reverts commit 68e2d26aa9e4afc71daba79520994c3076c67788. Revert "Bug 1989323 - Make `referenceTarget` IDL attributes on ShadowRoot, HTMLTemplateElement and ShadowRootInit nullable. r=dom-core,webidl,saschanaz,smaug" This reverts commit 1234b31599e69cab1784471925fa8c1802e3514f. gecko-commit: 11bf5d2392c34a6a70996e70ec388fd59e0e1265 gecko-reviewers: credential-management-reviewers, webidl, dimi, Jamie, smaug
This change adds attr-associated element observers, which observe changes in the element associated with a single-element attribute. For example, if an element has an attribute |attr| with a value |value|, and an AttrTargetObserver has been added for |attr| on that element, the observer would fire if an element with an ID matching |value| was added to the element's document or shadow root. Attr-associated element observers are tracked in mAttrElementObserverMap in an element's nsExtendedDOMSlots. An attr-associated element can change in multiple ways: - The attribute value changes; - An element matching the content attribute value is added or removed from the element's document or shadow root; - The explicitly-set attr element is added or removed from the element's document or shadow root; - The resolved reference target for the explicitly set attr-element or the element whose ID matches the string value of the attribute changes. The resolved reference target can likewise change in multiple ways: - The referenceTarget property of the element's shadow root is added, changed or removed; - An element whose ID matches the element's shadow root's referenceTarget value is added or removed from the shadow root; - The resolved reference target of the element whose ID matches the shadow root's referenceTarget value changes. These changes are tracked via reference target change observers, which observe changes to an element's resolved reference target. Reference target change observers are added on the host element's document or shadow root, and fired when one of the above circumstances occurs. Differential Revision: https://phabricator.services.mozilla.com/D261367 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1981346 gecko-commit: 158ecfa53fca60714aa23e27b9425ec85b2cbc67 gecko-reviewers: credential-management-reviewers, webidl, dimi, Jamie, smaug
* Map "Reversed counter-reset" to web-features * Map "Counters (CSS)" to web-features
…lc() in keyframe selectors (#56926) The keyframe selector grammar allows the use of calc() via the usage of the <percentage> production. This updates the test, changing the calc() usages from invalid to valid.
…ation-range (#56925) Previously, the test assumed that `animation-range: entry calc(0%) entry calc(100%)` could be simplified down to `animation-range: entry` for the specified value serialization, but CSS Value 4 requires calc() expressions to be not be simplified that far until the computed value. See example 46 (https://drafts.csswg.org/css-values-4/#example-c3db2475) for more.
…n tests in animate-with-background-color-oklch-002.html (#56924)
…sible `Text` nodes
The remaining case of bug 2005895 is, there is a invisible `Text`
between paragraphs like:
```html
<p>abc</p> <p>{}<br></p>
```
The reason is, `HTMLEditUtils::GetPreviousContent` is not called with
`WalkTreeOption::IgnoreWhiteSpaceOnlyText`. Therefore, I tried to
add the option in `AutoEmptyBlockAncestorDeleter::GetNewCaretPosition`.
However, the handling is odd [1]:
```cpp
static bool IsContentIgnored(const nsIContent& aContent,
const WalkTreeOptions& aOptions) {
```
<snip>
```cpp
if (aOptions.contains(WalkTreeOption::IgnoreWhiteSpaceOnlyText) &&
aContent.IsText() &&
const_cast<Text*>(aContent.AsText())->TextIsOnlyWhitespace()) {
return true;
}
```
So, whether the `Text` is actually visible or not is not tested.
Therefore, this does not work with preformatted content. However, I'd
like to uplift this to ESR140 so that it's too risky to change the
extant `HTMLEditUtils` implementation. Therefore, this patch makes
`GetNewCaretPosition` ignore invisible `Text` nodes directly.
1. https://searchfox.org/firefox-main/rev/20a1fb35a4d5c2f2ea6c865ecebc8e4bee6f86c9/editor/libeditor/HTMLEditUtils.h#3268-3269,3279-3282
Differential Revision: https://phabricator.services.mozilla.com/D277498
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2007618
gecko-commit: e2aa416202e65d156f5b8e4e217019f6cd7c4a04
gecko-reviewers: m_kato
The new tests verify that exhausting the quota of one Web Storage area does not significantly reduce the capacity available to the other one. Each test first measures the baseline capacity of one storage type by filling it until QuotaExceededError is thrown, then clears it, exhausts the other storage type, and measures the capacity again. Independence is verified by requiring that the second measurement remains broadly comparable to the baseline rather than collapsing to near-zero capacity, which would indicate a shared quota. Two directional tests are added: - sessionStorage retains comparable quota after localStorage exhaustion - localStorage retains comparable quota after sessionStorage exhaustion Gecko currently fails these new tests. This is consistent with the fact that the existing quota exhaustion tests also currently fail in Gecko. Signed-off-by: Jan Varga <[email protected]>
… (#56930) This is manual export of test cases added locally in WebKit below bug: https://bugs.webkit.org/show_bug.cgi?id=298540
For an inline box that had already generated some fragment, we were omitting additional fragments that would have had no content, padding, border nor margin. This basically happened when the inline was split by a block, e.g. `<span><div></div></span>`. However, other browsers agree that JS APIs like `getClientRects()` should include these empty fragments, so remove the optimization. Signed-off-by: Oriol Brufau <[email protected]>
Instead of the creation URL of the containing global, it should instead use the URL of the current worker. Despite the referrer specification stating that we should use the creation URL, instead browsers use the current URL. A new WPT test is added to cover that which we currently fail because of incorrect serialization of query parameters of a URL. But the actual redirect and all work now. Signed-off-by: Tim van der Lippe <[email protected]>
We shouldn't resolve the promise if underlying call threw. Fixed: 470784504 Change-Id: Id2eb2cd654a34afe4f083518ab3a4f3a827d596f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7318738 Reviewed-by: Vasilii Sukhanov <[email protected]> Commit-Queue: Andrey Kosyakov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1563321}
…ck to happen. This test seems questionable as written, because the anchored box fits at its "base" position without overflowing the IMCB, and therefore there doesn't seem to be any justification for applying fallbacks at all (see also w3c/csswg-drafts#13268). This patch forces fallbacks to be considered in all cases, by ensuring the base position always overflows and then providing a fallback that matches the "original" (non-overflowing) base position; then the browser will choose between this and the flipped fallback according to the specified position-try-order and writing modes involved. Differential Revision: https://phabricator.services.mozilla.com/D277557 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1989059 gecko-commit: 39886ca6f78ad20d48d3487dcbcbc2e1b638bbc4 gecko-reviewers: layout-anchor-positioning-reviewers, emilio
…=286597 (#56943) This is manual export because we were failing lint checks.
…ext inputs DOM APIs for interacting with selection and text in text inputs `<input type=text>` and `<textarea>` all accept offsets and lenghths in UTF-16 code units. Servo was not converting all of these offsets into UTF-8 code units. This change makes it so that this conversion is done more thoroughly and makes it clear when the code is dealing with UTF-8 offsets and UTF-16 offsets. Helper functions are added for doing this conversion in both directions as it is necessary. In addition, a `char` iterator is added for `TextInput` as it is useful for doing this conversion. It will be used more completely in the future when a `Rope` data structure is extracted from `TextInput`. Finally, specification text is added to all of the DOM implementation touched here. Signed-off-by: Martin Robinson <[email protected]>
… cases such as :host rule mismatch. Differential Revision: https://phabricator.services.mozilla.com/D277358 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2006172 gecko-commit: 7e7ba4dfff22630efd9a7a6926ce7678315baff5 gecko-reviewers: emilio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? đź’– Please sponsor : )