Fix wordpress api request test assertion #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While not setting `Cache-Control`, Some cache plugins will ignore method For example: It returns posts list while trying to create post Signed-off-by: Muhammed Hussain Karimi <[email protected]>
Co-authored-by: info <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Corrected incomplete
toHaveBeenCalledWithassertions inwordpressApiRequesttests withinpackages/nodes-base/nodes/Wordpress/__tests__/GenericFunctions.test.ts. Previously, thecredentialTypeargument was missing. This PR adds'wordpressApi'to the two affected assertions, ensuring complete and accurate test coverage forrequestWithAuthenticationcalls.Related Linear tickets, Github issues, and Community forum posts
N/A
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)