Add timeout for clipboard test #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
I'm still seeing this failing intermittently ocally on macOS... |
Contributor
|
Do you have any error message? Maybe we should pick a different |
Owner
Author
|
The error was just that the string in the clipboard was empty and so it failed the comparison. Seems to work fine in CI though. I thought maybe the check about it requiring a secure context was relevant since playwright headless may not be considered secure and so it’s using the deprecated approach. |
Contributor
|
Hm, odd, but it works for now in CI ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #313 I was getting a failed test intermittently for the AxisRadial and Bar clipboard tests, this seems to fix it.