Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces significant performance and safety improvements to the
jsoniterlibrary, focusing on JSON path navigation, Unicode handling, and iterator bounds checking. The changes eliminate callback-based iteration in favor of direct iteration patterns and optimize Unicode hex digit parsing.Key Changes
🚀 Performance Improvements
Path Navigation Refactoring
ReadObjectRaw()andReadArray()SkipAndReturnBytes()+ResetBytes()patternlocateObjectField→findObjectField,locateArrayElement→findArrayElement[]bytetoboolfor more efficient existence checkingUnicode Hex Parsing Optimization
c |= 0x20) to convert uppercase to lowercaseparseU4(),readU4(), andreadAndFillU4()methodsIterator Bounds Checking
isNextTokenBuffered(),trySkipNumber(), andskipString()iter.head < 0 || iter.head >= iter.tail || iter.tail > len(iter.buf)Benefits
Testing
iter_str_test.gocovering:\u0020)\u4e2d)\u4E2D)\u658U)Backward Compatibility
This refactoring maintains public API compatibility while changing internal implementation details. The path navigation behavior should remain functionally equivalent.