Thanks for the PR! I don't see anything wrong with it, I'll be merging it in due course.

Merged into my work branch as 814c2a0. Had to make a few small changes...

• opts was shadowing a variable in the outer scope, which MSVC complained about
• also, MSVC wasn't happy with assigning -1 to an unsigned type :)
• finally, clang-format also made a small tweak

I'll merge this to main once it passes CI.

• also, MSVC wasn't happy with assigning -1 to an unsigned type :)

IIRC the code in question treats 0 specially to mean "no limit", so it could also work. Haven't confirmed that though

• also, MSVC wasn't happy with assigning -1 to an unsigned type :)

IIRC the code in question treats 0 specially to mean "no limit", so it could also work. Haven't confirmed that though

Indeed, it's even documented as part of the command line option:

FOLLY_GFLAGS_DEFINE_int64(
    thrift_cpp2_debug_string_limit,
    256,
    "Limit on string size when debug-printing thrift, 0 is no limit");

I'll change that, this'll be easier to read than the numeric_limits stuff.