-
Notifications
You must be signed in to change notification settings - Fork 12
Add support to LLM Streaming #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add `Partial` associatedtype to `Generable` protocol with default Self. All implementations currently throw "not implemented" errors.
`@Generable` now emits a nested subtype for streaming use cases: ``` @generable struct T { // Fields here. } ``` now expands to: ``` struct T { // Fields here. } extension T: Generable { Partial { // partial fields } // Other generated fields. } ``` The rules for generating the partial subtypes are as follows: - `T?` => `T.Partial`, - otherwise: `T` => `T.Partial`
This should help avoid unwanted automatic defaults
Currently none of the backends support streaming, so marking the tests are disabled.
Tool use is still not supported
When a message is truncated, OpenAI returns `incomplete` event rather than `completed` event.
To avoid code duplication
- Unify generateResponse and generateResponseStream implementations - Both methods now use the same underlying streaming mechanism - Reduce code duplication and improve consistency - Maintain same API contract and error handling
Removed the 'sending' keyword from all AsyncThrowingStream return types across the streaming API. This affects: - LLM protocol methods (replyStream functions) - All backend implementations (OpenAI, Apple, MLX) - Test implementations (FakeLLM, CrashingLLM) - Documentation examples The streaming functionality remains unchanged, only the function signatures have been updated to remove the sending parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including structured output streaming via
Partialand tool loop.