Conversation
There was a problem hiding this comment.
PR Summary
This PR updates the CLI behavior and dependencies to support the nomic-ai/nomic-embed-text-v1.5 model while improving user experience.
- Added
einopsas optional dependency inpyproject.tomlto support nomic-ai/nomic-embed-text-v1.5 model - Modified CLI in
libs/infinity_emb/infinity_emb/cli.pyto automatically default to 'v2' command instead of showing error - Updated version from 0.0.74 to 0.0.75 in
libs/infinity_emb/pyproject.toml - Improved error messaging in CLI to better guide users about version deprecation and upgrade path
- Changed log level from critical to error for no-command case in CLI for better visibility
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| if len(sys.argv) == 1 or sys.argv[1] not in ["v1", "v2", "help", "--help"]: | ||
| logger.error( | ||
| "Error: No command given. Please use infinity with the `v2` command. " | ||
| f"This is deprecated since 0.0.32. You are on {infinity_emb.__version__}. " | ||
| "Usage: `infinity_emb v2 --model-id BAAI/bge-large-en-v1.5. " | ||
| "defaulting to `v2` since 0.0.75. Please pin your revision for future upgrades." | ||
| ) |
There was a problem hiding this comment.
syntax: The error message has a missing closing quote after BAAI/bge-large-en-v1.5
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 79.90% 79.86% -0.05%
==========================================
Files 43 43
Lines 3484 3486 +2
==========================================
Hits 2784 2784
- Misses 700 702 +2 ☔ View full report in Codecov by Sentry. |
| "defaulting to `v2` since 0.0.75. Please pin your revision for future upgrades." | ||
| ) | ||
|
|
||
| sys.argv.insert(1, "v2") |
There was a problem hiding this comment.
Will this take args from the env vars then?
I believe it will just like this:
https://huggingface.co/spaces/michaelfeil/infinity/blob/main/Dockerfile
There was a problem hiding this comment.
you can just run the docker file without the v2 command!
Related Issue
Checklist
Additional Notes
Add any other context about the PR here.