feat: add EXAT PXAT GET options to SET command #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for EXAT, PXAT, and GET options to the Redis SET command, aligning the implementation with Redis 6.2+ behavior. The changes enable setting expiration times as absolute Unix timestamps and retrieving the previous value atomically.
- Added EXAT (Unix seconds) and PXAT (Unix milliseconds) expiration options
- Implemented GET option to return the old value before setting new one
- Updated SetStringWithOptions signature to return previous value information
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/server/cmd_set.go | Implements EXAT, PXAT, and GET option parsing and handling in the SET command |
| internal/db/db.go | Updates SetStringWithOptions to return previous value and existence flag |
| internal/server/cmd_set_test.go | Adds comprehensive test coverage for new EXAT, PXAT, and GET options |
| internal/db/db_test.go | Updates existing tests to handle new return signature |
| README.md | Fixes markdown syntax for license link |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.