refactor: call store as database #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase by renaming the store package to db and moving the parseInt function to the resp package as ParseInt. The changes improve naming consistency and code organization.
- Renamed
Storetype toDBandstorepackage todb - Moved
parseIntutility function toresppackage asParseIntwith test coverage - Consolidated error definitions into a new
errors.gofile
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| minivalkey.go | Updated to use server.New() without explicit dependencies and call server.FastForward() |
| internal/server/server.go | Renamed store to db, moved parseInt to resp package, added FastForward and CleanUpExpired methods |
| internal/server/errors.go | Created new file to consolidate error definitions |
| internal/server/cmd_*.go | Updated all command handlers to use s.db instead of s.store |
| internal/server/cmd_*_test.go | Updated test files to use db.DB instead of store.Store |
| internal/resp/helpers.go | Added ParseInt function moved from server package |
| internal/resp/helpers_test.go | Added comprehensive test coverage for ParseInt |
| internal/db/db.go | Renamed from store.go, renamed Store to DB and data field to entries |
| internal/db/db_test.go | Updated package name and type references to use db.DB |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.