refactor: change handler signature #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors command handler signatures to accept a request object and Writer instead of separate command/args parameters, and introduces session support for multi-database functionality.
- Introduces session management for per-connection state tracking
- Changes handler function signature from
func(cmd, args, w)tofunc(w, r) - Replaces single DB instance with a map of databases indexed by session's selected DB
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/session/session.go | Adds new Session struct to track client connection state including selected database |
| internal/server/request.go | Introduces request wrapper containing session, command, and arguments |
| internal/server/server.go | Updates Server struct to use dbMap instead of single db, changes handler signatures, and adds db() helper method |
| internal/server/validator.go | Changes validateCommand from Server method to standalone function |
| internal/server/errors.go | Adds ErrUnknownSection error constant |
| internal/server/cmd_*.go | Updates all command handlers to use new signature (w, r) instead of (cmd, args, w) |
| internal/server/cmd_*_test.go | Updates tests to create request objects and use dbMap instead of single db |
| Makefile | Adds test-e2e and test-all targets for improved test organization |
| .github/workflows/test.yml | Updates CI workflow to run all tests using test-all target |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.