test: add tests for resp.Reader/Writer #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the RESP (REdis Serialization Protocol) reader and writer components, improving the reliability of the protocol implementation.
- Adds test suite for
resp.Writercovering all write operations (strings, errors, integers, bulk strings, arrays) - Adds test suite for
resp.Readerwith both success and error cases for reading array-bulk commands - Refactors an existing e2e test to use
t.Context()instead ofcontext.Background()
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/resp/writer_test.go | New test file covering all Writer methods including WriteString, WriteError, WriteInt, WriteBulk, and array operations |
| internal/resp/reader_test.go | New test file for Reader.ReadArrayBulk with validation of protocol errors and edge cases |
| e2e/basic_test.go | Updated to use t.Context() for automatic context cancellation and removed unused import |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.