-
Couldn't load subscription status.
- Fork 51
Referring packages in Bioc style #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ial_abundance.qmd
…into referring-packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, ready to go!
Check that BiocStyle is listed in DESCRIPTION and your name is in contributions.qmd
|
Will do! Just note that I haven't gone through all the chapters yet, I started this PR so I could get to fixing potential issues already instead of waiting for all chapters to be done. I will notify you when all chapters are done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you confirm that this is ready?
|
It is not yet ready, will probably be at the end of the week. I will inform you when it is! |
|
Cool! No worries, take your time! |
|
I have now finished all chapters! I want to point out that in resources.qmd (commit 1ee07f3) I also added the setup chunk in the beginning of the file since it was missing, and it was necessary for the BiocStyle to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you!
From Issue 798.
I changed all R package references to the Bioc style so it adds links automatically. I will do this to all the chapters in the OMA book.
I will also fix other small issues / faults that arise when fixing package referencing, e.g. making sure line width is still within 80 characters.