Refix tree loadings #217
Refix tree loadings #217
Conversation
DESCRIPTION
Outdated
| bluster, | ||
| circlize, | ||
| ComplexHeatmap, | ||
| GenomeInfoDb, |
There was a problem hiding this comment.
No, strictly for this no. But checks were throwing annoying errors that this fixed. Along with the correct links that where in the previous PR but omitted here.
There was a problem hiding this comment.
Can you check what these errors were?
The package is not directly related to miaViz, I think. The dependency comes probably from somewhere else, meaning that the dependency errors should be fixed there.
This is for controlling that the dependency list does not expand too much (the list is already too big)
There was a problem hiding this comment.
Seems it is not needed anymore. Removed.
There was a problem hiding this comment.
Wasn't there more improvements? Include all functional improvements related to plotloadings that were in the old PR. (The plot looked very nice in that PR if I remember correctly)
There was a problem hiding this comment.
I'll double back. Likely missed something, have since disabled all autoformating on save to prevent this mess in the future.
|
Should be the rest of the changes. Still feels like I might have missed something but can't spot. The function still needs some work I think, it throws many warning on invalid object types when plotting.. |
Resubmit of fixes applied in #212 WITHOUT autoformatting and unrelated fixes to links