Finalize quickPickButtonLocation API proposal #284360
Open
+40
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR finalizes the quickInputButtonLocation API proposal by moving it from a proposed API to a stable API in the VS Code extension API surface.
Key Changes
- Removed the proposal file and added the API definitions to the main vscode.d.ts
- Removed the proposal check requirement, allowing all extensions to use the API
- Simplified toggle button implementation by removing the separate Toggle widget management layer
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.quickInputButtonLocation.d.ts | Removed the proposal file as the API is now finalized |
| src/vscode-dts/vscode.d.ts | Added QuickInputButtonLocation enum and button properties (location and toggle) to the stable API |
| src/vs/workbench/api/common/extHostQuickOpen.ts | Removed proposal API checks and updated toggle property structure in transfer objects |
| src/vs/workbench/api/common/extHost.protocol.ts | Changed TransferQuickInputButton to use toggle object instead of checked boolean |
| src/vs/workbench/api/browser/mainThreadQuickOpen.ts | Removed separate Toggle widget management and simplified button handling to pass toggle state through button events |
| src/vs/platform/quickinput/browser/quickInputUtils.ts | Updated quickInputButtonToAction to swap label and tooltip parameters |
| src/vs/platform/extensions/common/extensionsApiProposals.ts | Removed quickInputButtonLocation from the list of API proposals |
| extensions/vscode-api-tests/package.json | Removed quickInputButtonLocation from enabled proposals |
| extensions/git/tsconfig.json | Removed reference to the proposal file |
| extensions/git/package.json | Removed quickInputButtonLocation from enabled proposals |
Member
|
@dmitrivMS PR is red |
Contributor
Author
Yeah, sorry - bad merge, will fix. |
Contributor
Author
Fixed |
TylerLeonhardt
approved these changes
Dec 26, 2025
Member
|
One thing worth discussing in API Sync... where should we put a It could change the shape of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144956