Use a button instead of a toggle for the theme picker #284367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it's just opening to settings, let's make it a button instead of a toggle. I also moved it from being an input button to an inline one which makes more sense since it takes you out of the picker. Maybe worth considering in a follow up turning this into a toggle (using the new `.toggle` property on `IQuickInputButton`) and then having the toggle turn the detection mode on and off. Modifying the setting without having to go to the settings view.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the theme picker UI to use a regular button instead of a toggle control for accessing color mode configuration settings. The button has been moved from an input button to an inline button location, which better reflects its purpose of navigating to the settings view rather than toggling state.
Key Changes:
- Replaced
IQuickInputTogglewithIQuickInputButtonfor the color mode configuration control - Changed button location from input area to inline (next to the quick pick input)
- Simplified the interface by replacing
togglesandonToggleproperties withbuttonsandonButton
dmitrivMS
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's just opening to settings, let's make it a button instead of a toggle. I also moved it from being an input button to an inline one which makes more sense since it takes you out of the picker.
Maybe worth considering in a follow up turning this into a toggle (using the new
.toggleproperty onIQuickInputButton) and then having the toggle turn the detection mode on and off. Modifying the setting without having to go to the settings view.FYI @aeschli