[rel/18.0] Disable DynamicNative instrumentation by default #15298
+237
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
commented
Oct 17, 2025
Youssef1313
reviewed
Oct 17, 2025
nohwnd
commented
Oct 17, 2025
Youssef1313
reviewed
Oct 17, 2025
|
LGTM but I would ASAP fix logic in code coverage repository for detection of .NET processes. Simple scenario in VS 18.0 will still fail with those changes:
This will continue failing because.
|
jakubch1
approved these changes
Oct 17, 2025
Youssef1313
reviewed
Oct 17, 2025
Youssef1313
approved these changes
Oct 17, 2025
|
@nohwnd Do we want to forward port to main? |
|
/backport to main |
nohwnd
added a commit
to nohwnd/vstest
that referenced
this pull request
Oct 20, 2025
* Disable DynamicNative instrumentation by default * Also commit tests * Apply suggestion from @nohwnd
nohwnd
added a commit
that referenced
this pull request
Oct 20, 2025
* Disable DynamicNative instrumentation by default * Also commit tests * Apply suggestion from @nohwnd
nohwnd
added a commit
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially fix dotnet/sdk#50950 by disabling the DynamicNative instrumentation by default for all code coverage versions.
This change applies the workaround 1 to all runs under vstest 18: dotnet/sdk#50950 (comment)
This reduces the blast radius of the linked issue. DynamicNative code coverage is not needed for projects that only deal with .NET (managed) components.
If user explicitly enables DynamicNative they will still see the error until a fixed version of Code Coverage is published that loads covrun64 in a way that is compatible with .NET 10.
This change will be effective in VSTest 18, including VisualStudio 18, and dotnet test in .NET 10 SDK 10.0.1xx.
User can globally opt out from this fix by setting
VSTEST_DISABLE_DYNAMICNATIVE_CODECOVERAGE_DEFAULT_SETTING=1. Or they can opt out per run by using runsettings and setting the value themselves to the desired value.