-
Notifications
You must be signed in to change notification settings - Fork 10
Deploy sample application in container app - Python #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Added CODEOWNERS * Added .gitignore --------- Co-authored-by: Johan Broberg <[email protected]>
Co-authored-by: Johan Broberg <[email protected]>
Co-authored-by: Johan Broberg <[email protected]>
Co-authored-by: Jesus Terrazas <[email protected]>
Co-authored-by: Johan Broberg <[email protected]>
Co-authored-by: Jesus Terrazas <[email protected]>
* Adding Python Agent Framework Sample * update to latest --------- Co-authored-by: Jesus Terrazas <[email protected]>
Co-authored-by: Rahul Devikar <[email protected]>
* Revise README for Agent 365 Sample Agent Updated the README to improve clarity and correct typos. Added sections on prerequisites, running the sample, and troubleshooting. * Update README to remove external sample reference Removed reference to the semantic-kernel-multiturn sample.
Co-authored-by: Rahul Devikar <[email protected]>
* update agents sdk version for langchain * Accept more recent versions * remove authority field, this is set by default --------- Co-authored-by: Jesus Terrazas <[email protected]>
* Adding Notifications on AF * Update readme * PR comments * small fix * removed observability * update manifest * changes * setup fix
Added comprehensive instructions for GitHub Copilot to follow during code reviews, including rules for checking keywords, copyright headers, and Agent 365 sample validation.
* update with api change * update claude to tool service api name change * name change --------- Co-authored-by: Jesus Terrazas <[email protected]>
* Add Vercel AI SDK sample * fix comments --------- Co-authored-by: Dominik Bezic <[email protected]>
* introducing perplexity sample agent * applying changes from code review * updated readme file with features list --------- Co-authored-by: aubreyquinn <[email protected]>
* Add OpenAI Nodejs Sample * fix: model to string * Add copyright headers * Add build script * fix typo * fix typo in doc * take comments * update doc for env name change * update license path in readme * update walkthrough to follow same structure as AF * include agentsplayground in readme --------- Co-authored-by: Jesus Terrazas <[email protected]>
…ion (#31) * Initial plan * Rename "Microsoft Agents A365" to "Microsoft Agent 365" Co-authored-by: pontemonti <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: pontemonti <[email protected]>
Co-authored-by: Jesus Terrazas <[email protected]>
* add updated nodejs claude implementation * fix typos * change mcp endpoint to prod * review comments * add auth from agents-hosting * remove lock
* quickstart initial code * rename folder * update docs on quickstart * add links and update docs * include rename change * copilot suggestions --------- Co-authored-by: Jesus Terrazas <[email protected]>
* Introducing playground notification handling in Perplexity agent * Introducing playground Teams messaging notification handling in Perplexity agent * applying changes from code review * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * applying changes from code review * Add missing copyright header to playgroundActivityTypes.ts (#36) * Initial plan * Add Microsoft copyright header to playgroundActivityTypes.ts Co-authored-by: aubreyquinn <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: aubreyquinn <[email protected]> * Add copyright header to playgroundActivityTypes.ts (#35) * Initial plan * Add Microsoft copyright header to playgroundActivityTypes.ts Co-authored-by: aubreyquinn <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: aubreyquinn <[email protected]> --------- Co-authored-by: aubreyquinn <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Copilot <[email protected]>
* Cursor IDE prompt usage --------- Co-authored-by: shirahman <[email protected]>
* Update samples to remove environment id from calls and settings * remove env id from newer samples * Update python/agent-framework/sample-agent/.env.template Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Jesus Terrazas <[email protected]> Co-authored-by: Copilot <[email protected]>
* Fix formatting of 'Microsoft Agent365' to 'Microsoft Agent 365' * Update README to reflect Microsoft Agent 365 SDK * Fix typo in Agent365 authentication comment * Fix comment formatting in client.ts Updated comments to improve clarity and consistency. * Fix typo in AGENT-TESTING.md * Fix description formatting in pyproject.toml * Update package description for clarity * Fix formatting of Agent 365 configuration comment * Update README to reference Microsoft Agent 365 SDK * Fix typo in Agent 365 Observability SDK comment * Update package description for clarity * Fix description formatting in pyproject.toml * Fix formatting in .env.template for Agent 365 * Update README.md * Update README.md * Fix naming in README for Agent Framework and SDK Updated README to correct naming conventions for Agent Framework and Microsoft Agent 365 SDK. * Update license link in README.md * Update perplexityClient.ts * Update README to reference Microsoft Agent 365 SDK * Fix typo in LangChain client documentation * Update README to reflect Microsoft Agent 365 SDK
- Add Application Insights SDK dependencies (opencensus-ext-azure, azure-monitor-opentelemetry) - Implement optional telemetry configuration in agent.py with graceful fallback - Add ENABLE_APPLICATION_INSIGHTS and APPLICATIONINSIGHTS_CONNECTION_STRING to .env.template - Create comprehensive APPLICATION_INSIGHTS.md documentation with setup guide - Update README.md to mention Application Insights as an optional feature - Fix host_agent_server.py to bind to 0.0.0.0 for container compatibility
- Add service connection authentication variables (CLIENT_ID, CLIENT_SECRET, TENANT_ID, SCOPES) - Add agentic user authorization configuration - Add ENABLE_OTEL and ENABLE_SENSITIVE_DATA for observability - Add Application Insights configuration (optional) - Add container app logs viewing step - All env vars now match .env.template requirements
- Add service connection authentication variables (CLIENT_ID, CLIENT_SECRET, TENANT_ID, SCOPES) - Add agentic user authorization configuration - Add ENABLE_OTEL and ENABLE_SENSITIVE_DATA for observability - Add Application Insights configuration (optional) - Add container app logs viewing step - All env vars now match .env.template requirements
a55f300 to
a18f5a9
Compare
🚀 Deployment Successful!Your Python Agent Framework has been deployed to Azure Container Apps. 🔗 Deployment Links
📦 Deployment Details
🧪 Testing with Agents PlaygroundOption 1: Direct Testing (Simple)# Check health
curl https://agent-framework-python.proudbush-4649d800.eastus.azurecontainerapps.io/api/health
# Send a test message (requires authentication)
curl -X POST https://agent-framework-python.proudbush-4649d800.eastus.azurecontainerapps.io/api/messages \
-H "Content-Type: application/json" \
-d '{"type":"message","text":"Hello Agent!"}'Option 2: Test with Agents Playground (Interactive)
Deployed from commit a2493d8 by @tirthdoshi009 |
🚀 Deployment Successful!Your Python Agent Framework has been deployed to Azure Container Apps. 🔗 Deployment Links
📦 Deployment Details
🧪 Testing with Agents PlaygroundOption 1: Direct Testing (Simple)# Check health
curl https://agent-framework-python.proudbush-4649d800.eastus.azurecontainerapps.io/api/health
# Send a test message (requires authentication)
curl -X POST https://agent-framework-python.proudbush-4649d800.eastus.azurecontainerapps.io/api/messages \
-H "Content-Type: application/json" \
-d '{"type":"message","text":"Hello Agent!"}'Option 2: Test with Agents Playground (Interactive)
Deployed from commit ea6be0a by @tirthdoshi009 |
|
@tirthdoshi009 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
| @@ -0,0 +1,283 @@ | |||
| name: Deploy Python Agent Framework to Azure Container Apps | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this has to be in .github workflow folders? This sounds like it's specific to agent framework. Shouldn't it be moved to sample agent folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| --memory 1.0Gi \ | ||
| --env-vars \ | ||
| PORT=3978 \ | ||
| AZURE_OPENAI_ENDPOINT=${{ secrets.AZURE_OPENAI_ENDPOINT }} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if someone wants to use some other llm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point Rahul. The purpose of this workflow is help users test their changes without having to deploy any models. That's the reason of defaulting to one.
If one wants to use another model, the best way is locally running in that case.
| --tail 50 \ | ||
| --follow false | ||
|
|
||
| - name: Comment on PR with Deployment URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fully following the this yml. Is the expectation to deploy this sample from this repo itself? What is the use case and business need? What if someone wants to use non-azure infrastructure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah apologies, I might have not specified the context. We are working on an AI first project that needs verification of the packages. For example, if copilot makes any changes to the sdk, we want to ensure that the changes don't really affect the execution of the sdk.
This workflow helps to verify that the changes are deployed and verified correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, I don't think this is a right approach to validate the SDK. There is an entire E2E integration test feature being built right now that deploys the samples to the resource group and test different areas. In your case, you are just checking if the app is healthy or not, but that does not guarantee if the application components where changes were made is correct. Besides that, you are exposing the secrets in the pipeline in OSS, which any PR can expose secrets to outside world(obviously they will fork, but still there are number of reason we should avoid secrets in pipeline)
rahuldevikar761
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes related to docker-container is seems somewhat specific to business need. I'm not seeing what is the requirement to deploy agent from the github repo itself.
No need for this markdown. Created by copilot
…m/microsoft/Agent365-Samples into users/tirthdoshi/local-playground
The sample application was not receiving a response when we ran agentsplayground. This change makes sure that when we run the agentsplayground, we can get responses from the agent directly on the window of agentsplayground.
Testing: