Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Email] Fix concurrency issues #4022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2025
Merged

[Email] Fix concurrency issues #4022

merged 3 commits into from
Jul 2, 2025

Conversation

@gggdttt
Copy link
Contributor

@gggdttt gggdttt commented Jul 1, 2025 •
edited by github-actions bot
Loading

Summary

Work Item(s)

Fixes AB#582364

@gggdttt gggdttt requested a review from a team as a code owner July 1, 2025 22:28
@github-actions github-actions bot added this to the Version 27.0 milestone Jul 1, 2025
NKarolak
NKarolak suggested changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@NKarolak NKarolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the other PRs:

  • [26.x] [Email Retry] Fix concurrency issues #4023
  • [26.3] [Email Retry] Fix concurrency issues #4024

@gggdttt gggdttt enabled auto-merge (squash) July 2, 2025 07:26
@gggdttt gggdttt requested a review from NKarolak July 2, 2025 07:26
@NKarolak
Copy link
Contributor

NKarolak commented Jul 2, 2025

Just to be sure: My ClientType suggestion was rejected (also by approver @darjoo), or was it just overlooked?

@gggdttt
Copy link
Contributor Author

gggdttt commented Jul 2, 2025 •
edited
Loading

Hi @NKarolak Thanks for your review :)
I went through the code and found both ClientType and CLIENTTYPE exist. (Personally I prefer CLIENTTYPE )

@NKarolak
Copy link
Contributor

NKarolak commented Jul 2, 2025

Hi @NKarolak Thanks for your review :) I went through the code and found both ClientType and CLIENTTYPE exist. (Personally I prefer CLIENTTYPE )

But according to the AL language, only ClientType is correct ;-)
CLIENTTYPE is very much C/AL.

@gggdttt gggdttt merged commit 1528ca9 into main Jul 2, 2025
30 checks passed
@gggdttt gggdttt deleted the private/wenjiefan/fix-email-concurrency-issue branch July 2, 2025 07:54
@gggdttt
Copy link
Contributor Author

gggdttt commented Jul 2, 2025 •
edited
Loading

@NKarolak This PR is auto merged... I shall create another PR to change it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darjoo darjoo darjoo approved these changes

@haoranpb haoranpb haoranpb approved these changes

@NKarolak NKarolak Awaiting requested review from NKarolak

Assignees

No one assigned

Labels

AL: System Application

Projects

None yet

Milestone

Version 27.0

Development

Successfully merging this pull request may close these issues.

5 participants

@gggdttt @NKarolak @darjoo @haoranpb