Add indirect permissions to ScheduledPerfProfilerImpl codeunit #4342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbuyuka
approved these changes
Aug 4, 2025
haoranpb
approved these changes
Aug 4, 2025
darjoo
added a commit
that referenced
this pull request
Aug 4, 2025
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> GDAP users are affected when this code is run from various places and prevents them from performing their action. They have the license permission for indirect insert but not direct insert. This adds indirect read and indirect insert to the permissions on the codeunit. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#595852](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/595852)
darjoo
added a commit
that referenced
this pull request
Aug 4, 2025
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> GDAP users are affected when this code is run from various places and prevents them from performing their action. They have the license permission for indirect insert but not direct insert. This adds indirect read and indirect insert to the permissions on the codeunit. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#595852](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/595852)
darjoo
added a commit
that referenced
this pull request
Aug 4, 2025
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> GDAP users are affected when this code is run from various places and prevents them from performing their action. They have the license permission for indirect insert but not direct insert. This adds indirect read and indirect insert to the permissions on the codeunit. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#595852](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/595852)
darjoo
added a commit
that referenced
this pull request
Aug 4, 2025
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> GDAP users are affected when this code is run from various places and prevents them from performing their action. They have the license permission for indirect insert but not direct insert. This adds indirect read and indirect insert to the permissions on the codeunit. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#595852](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/595852)
darjoo
added a commit
that referenced
this pull request
Aug 4, 2025
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> GDAP users are affected when this code is run from various places and prevents them from performing their action. They have the license permission for indirect insert but not direct insert. This adds indirect read and indirect insert to the permissions on the codeunit. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#595852](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/595852)
darjoo
added a commit
that referenced
this pull request
Aug 4, 2025
… codeunit (#4343) This pull request backports #4342 to releases/26.x Fixes [AB#595909](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/595909)
darjoo
added a commit
that referenced
this pull request
Aug 4, 2025
… codeunit (#4344) This pull request backports #4342 to releases/26.3 Fixes [AB#595907](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/595907)
darjoo
added a commit
that referenced
this pull request
Aug 4, 2025
… codeunit (#4345) This pull request backports #4342 to releases/26.2 Fixes [AB#595906](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/595906)
darjoo
added a commit
that referenced
this pull request
Aug 4, 2025
… codeunit (#4346) This pull request backports #4342 to releases/26.1 Fixes [AB#595905](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/595905)
darjoo
added a commit
that referenced
this pull request
Aug 4, 2025
… codeunit (#4347) This pull request backports #4342 to releases/26.0 Fixes [AB#595904](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/595904)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GDAP users are affected when this code is run from various places and prevents them from performing their action.
They have the license permission for indirect insert but not direct insert.
This adds indirect read and indirect insert to the permissions on the codeunit.
Work Item(s)
Fixes AB#595852