Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Word Template] Fix unexpected behavior of AddUnrelatedTable #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 4, 2025
Merged

[Word Template] Fix unexpected behavior of AddUnrelatedTable #3135

merged 8 commits into from
Mar 4, 2025

Conversation

@zeande
Copy link
Contributor

@zeande zeande commented Mar 3, 2025 •
edited by github-actions bot
Loading

Summary

This change addresses two issues that were present in the AddUnrelatedTable method.

  1. The result of the implementation method call is returned so that callers know if the record was successfully added.
  2. The "Word Templates Related Table" record that is created has the word template code assigned to it that was provided by the caller.

Work Item(s)

Fixes #3105

Fixes AB#567861

@zeande zeande requested a review from a team as a code owner March 3, 2025 10:11
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Mar 3, 2025
@zeande zeande mentioned this pull request Mar 3, 2025
Closed
@JesperSchulz JesperSchulz added Linked Issue is linked to a Azure Boards work item Integration GitHub request for Integration area labels Mar 3, 2025
@github-actions github-actions bot added this to the Version 27.0 milestone Mar 3, 2025
stkillen
stkillen reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@stkillen stkillen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - can we just fix the naming of the test methods?

@stkillen
Copy link
Contributor

stkillen commented Mar 3, 2025

There are test failures. The number series one is unrelated, but please fix failures related to this.

Build: src/System Application/Test/Word Templates/src/WordTemplatesTest.Codeunit.al#L31AL0185 Codeunit 'Any' is missing
Build: src/System Application/Test/Word Templates/src/WordTemplatesTest.Codeunit.al#L64AL0185 Codeunit 'Any' is missing
Build: src/System Application/Test/Word Templates/src/WordTemplatesTest.Codeunit.al#L87AL0185 Codeunit 'Any' is missing

@JesperSchulz JesperSchulz merged commit 9144dd7 into microsoft:main Mar 4, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JesperSchulz JesperSchulz JesperSchulz approved these changes

@stkillen stkillen stkillen approved these changes

Assignees

No one assigned

Labels

AL: System Application From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item

Projects

None yet

Milestone

Version 27.0

Development

Successfully merging this pull request may close these issues.

[Bug]: "Word Template".AddUnrelatedTable method not working as expected

3 participants

@zeande @stkillen @JesperSchulz