Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PT Run] Implement quick browser open in PT-run #11260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2021
Merged

[PT Run] Implement quick browser open in PT-run #11260

merged 2 commits into from
May 14, 2021

Conversation

@Lee-WonJun
Copy link
Contributor

@Lee-WonJun Lee-WonJun commented May 13, 2021 •
edited
Loading

Implement quick browser open in PT-run

What is this about:
Added quick default browser launch function in Uri plugin

What is include in the PR:
source code

How does someone test / validate:
Type only direct activation phrase (by default "//") in PT run and check if the item that open default browser is displayed.

Quick browser
image

Original plugin
image

review plz!

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@Lee-WonJun Lee-WonJun changed the title Implement quick browser open in PT-run [PT Run] Implement quick browser open in PT-run May 13, 2021
@htcfreek
Copy link
Collaborator

htcfreek commented May 13, 2021 •
edited
Loading

@Lee-WonJun
I know the following suggestion a bit out of PR's scoope:

  • Should we update the subtitle to Open in default browser?
  • And I think we don't need the subtitle on the result for // or we can maybe optimize it. (Otherwise we have same result name and subtitle.)

@htcfreek htcfreek added Run-Plugin Manager Issues with the PowerToys Run plugin manager Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Things that relate with PowerToys Run's plugin interface and removed Run-Plugin Manager Issues with the PowerToys Run plugin manager labels May 13, 2021
@Lee-WonJun
Copy link
Contributor Author

@Lee-WonJun
I know the following suggestion a bit out of PR's scoope:

* Should we update the subtitle to `Open in default browser`?

* And I think we don't need the subtitle on the result for `//` or we can maybe optimize it. (Otherwise we have same result name and subtitle.)

I agree with your opinion.
Which title and subtitle would you like?
I also thought about removing the subtitle. However, I didn't find any elements without subtitle in other plugins.
It seems to be unity that this is had subtitle

@htcfreek
Copy link
Collaborator

htcfreek commented May 13, 2021 •
edited
Loading

@Lee-WonJun
I know the following suggestion a bit out of PR's scoope:

* Should we update the subtitle to `Open in default browser`?

* And I think we don't need the subtitle on the result for `//` or we can maybe optimize it. (Otherwise we have same result name and subtitle.)

I agree with your opinion.
Which title and subtitle would you like?
I also thought about removing the subtitle. However, I didn't find any elements without subtitle in other plugins.
It seems to be unity that this is had subtitle

I suggest:

  • uri result: Open in default browser

  • // result: name=<browser name> and subtitle=Open default browser

@Lee-WonJun
Copy link
Contributor Author

Lee-WonJun commented May 14, 2021 •
edited
Loading

@Lee-WonJun
I know the following suggestion a bit out of PR's scoope:

* Should we update the subtitle to `Open in default browser`?

* And I think we don't need the subtitle on the result for `//` or we can maybe optimize it. (Otherwise we have same result name and subtitle.)

I agree with your opinion.
Which title and subtitle would you like?
I also thought about removing the subtitle. However, I didn't find any elements without subtitle in other plugins.
It seems to be unity that this is had subtitle

I suggest:

  • uri result: Open in default browser
  • // result: name=<browser name> and subtitle=Open default browser

good,
But there is one problem.
When I get the path of the default browser
Then I am able to get the name of the exe also.
But it also depends on the exe file name. (Example: "Firefox" is displayed "firefox", "Microsoft Edge" is displayed "msedge")
In my opinion, it is good that the title is just displayed as the "Default Browser".
However, the problem is that the difference between subtitles and titles disappears.

Have a good opinion?

Another idea of ​​mine is that it prints "Open Default Browser" in the title and the browser path in the subtitle.

@htcfreek
Copy link
Collaborator

htcfreek commented May 14, 2021 •
edited
Loading

@Lee-WonJun
I know the following suggestion a bit out of PR's scoope:

* Should we update the subtitle to `Open in default browser`?

* And I think we don't need the subtitle on the result for `//` or we can maybe optimize it. (Otherwise we have same result name and subtitle.)

I agree with your opinion.
Which title and subtitle would you like?
I also thought about removing the subtitle. However, I didn't find any elements without subtitle in other plugins.
It seems to be unity that this is had subtitle

I suggest:

  • uri result: Open in default browser
  • // result: name=<browser name> and subtitle=Open default browser

good,
But there is one problem.
When I get the path of the default browser
Then I am able to get the name of the exe also.
But it also depends on the exe file name. (Example: "Firefox" is displayed "firefox", "Microsoft Edge" is displayed "msedge")
In my opinion, it is good that the title is just displayed as the "Default Browser".
However, the problem is that the difference between subtitles and titles disappears.

Have a good opinion?

Another idea of ​​mine is that it prints "Open Default Browser" in the title and the browser path in the subtitle.

Let's go with your second idea: path in subtitle or we add an blank line as subtitle/remove it.

mykhailopylyp
mykhailopylyp reviewed May 14, 2021
View reviewed changes
@Lee-WonJun
Copy link
Contributor Author

@mykhailopylyp @htcfreek
I changed the source code. Check plz

123123

However, here are the following additional issues.

  1. Since Regedit is used, the default browser does not change until re-login.
  2. No support for UWP browser apps

@mykhailopylyp
Copy link
Contributor

@Lee-WonJun

  1. Since Regedit is used, the default browser does not change until re-login.
  2. No support for UWP browser apps

These issues apply to the plugin not just to this issue. So we don't have to fix it in this PR. Feel free to open a new issue for it.

mykhailopylyp
mykhailopylyp approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@mykhailopylyp mykhailopylyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested, works as expected. Thank you for your contribution!

@htcfreek
Copy link
Collaborator

@Lee-WonJun
Great.

The path for default browser looks strange. Does your local uses an other character instead of \?

@htcfreek
Copy link
Collaborator

@Lee-WonJun
Can you plz replace the gif in PR rescription with two screenshots. Thank you.

@Lee-WonJun
Copy link
Contributor Author

Lee-WonJun commented May 14, 2021 •
edited
Loading

@Lee-WonJun
Great.

The path for default browser looks strange. Does your local uses an other character instead of \?

yes, in my country (Korea), Currency symbol ( KRW/ U+20A9) is same the ''
image

@Lee-WonJun
Can you plz replace the gif in PR rescription with two screenshots. Thank you.

Yes, I modified the description. Did I understand it correctly?

@htcfreek
Copy link
Collaborator

@Lee-WonJun

Can you plz replace the gif in PR rescription with two screenshots. Thank you.

Yes, I modified the description. Did I understand it correctly?

yes

htcfreek
htcfreek suggested changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last small nit. Thanks for your contribution.

davidegiacometti
davidegiacometti approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@davidegiacometti davidegiacometti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution.

@crutkas crutkas merged commit de9b777 into microsoft:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidegiacometti davidegiacometti davidegiacometti approved these changes

@enricogior enricogior Awaiting requested review from enricogior

@crutkas crutkas Awaiting requested review from crutkas

+2 more reviewers

@mykhailopylyp mykhailopylyp mykhailopylyp approved these changes

@htcfreek htcfreek htcfreek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Lee-WonJun Lee-WonJun

Labels

Idea-Enhancement New feature or request on an existing product Product-PowerToys Run Improved app launch PT Run (Win+R) Window Run-Plugin Things that relate with PowerToys Run's plugin interface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Lee-WonJun @htcfreek @mykhailopylyp @davidegiacometti @crutkas