Changes to support the compiler portion of P1152R4 "deprecating volatile" #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `<optional>`: `optional::value_or` now returns `remove_cv_t<_Ty>` because it's silly to have a cv-qualified return type (Needs LWG issue). * `<variant>`: Suppress deprecation warnings when forming the "imaginary" overload set `FUN` for the `variant(T&&)` constructor. * Add the new warning C5215 "'%s' a function parameter with volatile qualified type is deprecated in C++20" to libc++'s "suppress deprecation warnings" macro and update llvm submodule reference. * Skip libc++ test `containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp` after seeing one timeout too many in Contest logs. * Suppress C5215 in `tr1/include/tfuns.h` which uses volatile function parameters. * Update skips for two libc++ tests that changed suffixes from `.sh.cpp` to `.pass.cpp`.
* `std::any_cast` should never return a cv-qualified type * Guard `_Implicitly_convert_to` against C5215 * Disable C5215 in `tr1/functional4`
CaseyCarter
commented
Apr 2, 2020
| // common header for functional?.cpp | ||
|
|
||
| #pragma warning(push) | ||
| #pragma warning(disable : 5215) // '%s' a function parameter with volatile qualified type is deprecated in C++20 |
There was a problem hiding this comment.
The warning push/disable/pop is the only functional change to this header; I made a non-functional drive-by fix to some weird formatting on lines 135-220.
CaseyCarter
commented
Apr 2, 2020
|
|
||
| template <class _Ty2> | ||
| _NODISCARD constexpr _Ty value_or(_Ty2&& _Right) const& { | ||
| _NODISCARD constexpr remove_cv_t<_Ty> value_or(_Ty2&& _Right) const& { |
There was a problem hiding this comment.
I've submitted an LWG issue (but not yet been assigned a number) to make the changes to both value_or overloads Standard.
...per the wording changes in as-yet-unnumbered LWG issues.
StephanTLavavej
approved these changes
Apr 3, 2020
| #pragma warning(disable : 4242) // 'identifier': conversion from '_From' to '_To', possible loss of data (/Wall) | ||
| #pragma warning(disable : 4244) // 'argument': conversion from '_From' to '_To', possible loss of data | ||
| #pragma warning(disable : 4365) // 'argument': conversion from '_From' to '_To', signed/unsigned mismatch (/Wall) | ||
| #pragma warning(disable : 5215) // '%s' a function parameter with a volatile qualified type is deprecated in C++20 |
There was a problem hiding this comment.
I find it somewhat interesting that you don't need to suppress Clang -Wdeprecated-volatile here. But if there are no warnings in our test suite, I'm happy.
There was a problem hiding this comment.
We probably should; this will be in some future set of "suppress clang warnings that don't show up because system header" 🤷♂ .
.... to enable libcxx to continue working after upstream changes to pass configuration to the filesystem tests which we do not run.
cbezault
approved these changes
Apr 3, 2020
CaseyCarter
commented
Apr 3, 2020
StephanTLavavej
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cppafter seeing one timeout too many in Contest logs.tr1/include/tfuns.hwhich uses volatile function parameters..sh.cppto.pass.cpp.[This is a dual of internal MSVC-PR-239335.]