Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cherry-pick 2 tickets after the ICU 68.2 release#63

Merged
jefgen merged 3 commits intomasterfrom
user/jefgen/icu68-cherry-pick-fixes
Jan 20, 2021
Merged

Cherry-pick 2 tickets after the ICU 68.2 release#63
jefgen merged 3 commits intomasterfrom
user/jefgen/icu68-cherry-pick-fixes

Conversation

@jefgen
Copy link
Member

@jefgen jefgen commented Jan 20, 2021

Summary

This PR cherry-picks two tickets from the upstream ICU repo that were merged after the ICU 68.2 release.

  • ICU-21427 Don't ignore already checked-in files under "tools/cldr/lib"
  • ICU-21118 check that dst and src are not null in uprv_memcpy

The first one I had already done with #52, so this is mostly just making an update for the comments and to record it in the changelog.md file.

The second one was fixed by @erik0686, and prevents undefined behavior in ultag_parse.

PR Checklist

  • I have verified that my change is specific to this fork and cannot be made upstream.
  • I am making a maintenance related change.
  • I am making a change that is related to usage internal to Microsoft.
  • I am making a change that is related to the Windows OS build of ICU.
  • CLA signed. If not, please see here to sign the CLA.

@jefgen jefgen requested review from a team, daniel-ju and erik0686 January 20, 2021 19:13
@erik0686
Copy link
Contributor

Thanks!

@jefgen jefgen merged commit 9c3587b into master Jan 20, 2021
@jefgen jefgen deleted the user/jefgen/icu68-cherry-pick-fixes branch January 20, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments