Add Valgrind build and test to CI pipeline #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefgen
approved these changes
Apr 14, 2021
Member
jefgen
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this! :)
Member
|
Note: Please use a squash merge if you merge this PR. |
daniel-ju
approved these changes
Apr 14, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the necessary steps to run Valgrind on PR's made to this repo.
Worth mentioning that unlike upstream ICU, where valgrind is run on batches of PR's, we will run it for every PR made here :)
PR Checklist
Detailed Description