Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Windows symbols publishing in the Nuget pipeline.#98

Merged
jefgen merged 2 commits intomasterfrom
user/jefgen/fix-symbols-publishing
Apr 15, 2021
Merged

Fix Windows symbols publishing in the Nuget pipeline.#98
jefgen merged 2 commits intomasterfrom
user/jefgen/fix-symbols-publishing

Conversation

@jefgen
Copy link
Member

@jefgen jefgen commented Apr 15, 2021

Summary

Since the Nuget creation and Nuget code signing are now done as two separate stages in the build pipeline, the Windows symbols publishing task fails as it relied on the DownloadBuildArtifacts tasks in the Nuget creation step. (This was missed in the refactoring of the pipeline in PR #93.)
However, since the Nuget doesn't contain any symbols at all, we can move the DownloadBuildArtifacts tasks entirely to the Nuget code signing stage instead.

Also, it turns out that the PublishSymbols task cannot run on the public Azure Pipelines pool and must be run on the PackageES pool. (Note: I skipped the actual publish step when testing PR #93, as you can't unpublish things once published. However, when running the Release Pipeline to publish for real, it errors out.)
Note: FWIW, the ProjectReunion pipeline also uses the PackageES lab for publishing symbols as well here:
https://github.com/microsoft/ProjectReunion/blob/1714557cad5e740c0153e451fbf0311c8e5bdfc1/build/ProjectReunion-BuildFoundation.yml#L172-L188

PR Checklist

  • I have verified that my change is specific to this fork and cannot be made upstream.
  • I am making a maintenance related change.
  • I am making a change that is related to usage internal to Microsoft.
  • I am making a change that is related to the Windows OS build of ICU.
  • CLA signed. If not, please see here to sign the CLA.

@jefgen jefgen requested review from a team, daniel-ju and erik0686 April 15, 2021 01:47
@huichen123
Copy link

That's interesting. Documentation/Symbols team never mentioned it requires Package ES pool. But I guess we can live with it as long as it works.

@jefgen jefgen merged commit 7b46fba into master Apr 15, 2021
@jefgen jefgen deleted the user/jefgen/fix-symbols-publishing branch April 15, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants