-
Notifications
You must be signed in to change notification settings - Fork 291
Override ApiException.Message getter to include ResponseStatusCode #6951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Override ApiException.Message getter to include ResponseStatusCode #6951
Conversation
baywet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
We'll need to coordinate this change across languages to provide a consistent experience. Can you please update the other languages?
|
@baywet I'm only qualified to write/judge C# code, but if it's OK to have Claude and Copilot to write that code and you trust the unit tests and your own due process, I'll include other languages. |
|
@microsoft-github-policy-service agree company="Logiqs" |
|
just for context I'm holding review until we merge #6953 since I believe those PRs will conflict a lot with each other. |
3d82525 to
8d55c2b
Compare
|
@baywet What's the plan for these PRs? |
|
@koen-lee Thank you for your patience. I'm happy to help you get those merged as long as the feedback I've provided is addressed. I think a first step for this one would be to handle the conflicts. |
…-ApiException-Message
The merge conflict has been addressed. |
baywet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to help you get this PR merged, but moving forward (other PRs) @adrian05-ms and @gavinbarron + others on the team should be helping you :)
|
@koen-lee would you please mind:
|
|
Thanks, will do. Also, I see some Go and Typescript integration test failures; I'll try to eliminate those too. |
See #4349; the default exception details are not very helpful.
This PR intends to add the
ResponseStatusCode, property of the baseApiException, to the message when no primary message extension is used.It's not great, the suggestion from the above issue to add the description from the spec is better, but this is (hopefully) an incremental improvement, relatively low impact, and may serve as an example for future improvements by pointing at the relevant code.
Considerations:
ResponseStatusCodeis mutable.