Update versioning to require the OMI superproject #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Another iteration is coming, you might want to hold off on review. |
940057d to
9caa550
Compare
Contributor
Author
|
Okay, this is fixed to be forgiving if version file does not exist. Please review. @Microsoft/ostc-devs |
|
Signed off |
ShirelyGu
pushed a commit
that referenced
this pull request
Aug 3, 2023
* adding sslciphersuits defaults * reverting omicli.conf change * default ssl cipher suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update versioning to use the Build-omi superproject. Due to issues with MI versioning, we can't generate a "bogus" version file if the version file doesn't exist. As a result, this commit will REQUIRE that the super-project be used to build OMI.
This is in preparation for upcoming work to build native installers (both rpm and deb, if possible) as part of the normal OMI non-developer build.
@Microsoft/ostc-devs
@Microsoft/omi-devs