Changes to wsman-client-feautre to enable build on aix,hpux,solaris and macos. #70

yakman2020 · 2016-09-14T22:12:20Z

No description provided.

palladia · 2016-09-14T22:52:48Z

Some comments, but look ok generally.

palladia · 2016-09-14T22:34:53Z

Unix/common/MI.h

+    _Inout_   MI_DestinationOptions *options,
+    _In_z_ const MI_Char *certsdir)
+{
+    if (options && options->ft)


Since you're checking parameters, may as well check certsdir too.

if (options && options->ft && certsdir)

palladia · 2016-09-14T22:35:12Z

Unix/common/MI.h

+    _In_   const MI_DestinationOptions *options,
+    _Outptr_result_z_ const MI_Char **certsdir)
+{
+    if (options && options->ft)


check certsdir here too.

palladia · 2016-09-14T22:41:30Z

Unix/tests/codec/mof/blue/consts.c

+    },
+
+    {NULL, 0, MI_RESULT_OK, 0, 0, NULL, NULL, NULL}
+};


No idea what's changed here.

Line endings, probably

palladia · 2016-09-14T22:42:09Z

Unix/wsman/wsmanerrorhandling.h

+END_EXTERNC
+
+
+


Again, can't tell what's changed.

line endings. dos line endings are preventing the build on solaris.

palladia · 2016-09-14T22:44:07Z

Unix/build.mak

 ifdef BUILD_TESTS
 tests:
-	( LD_LIBRARY_PATH=$(LIBDIR); export LD_LIBRARY_PATH; DYLD_LIBRARY_PATH=$(LIBDIR); export DYLD_LIBRARY_PATH; $(BINDIR)/nits -file:$(TMPDIR)/nitsargs.txt )
+	sudo sh -c "( LD_LIBRARY_PATH=$(LIBDIR); export LD_LIBRARY_PATH; DYLD_LIBRARY_PATH=$(LIBDIR); export DYLD_LIBRARY_PATH; $(BINDIR)/nits -file:$(TMPDIR)/nitsargs.txt )"


I assume there's a reason for sudo here, and in other places. Nevertheless, this bothers me...

Currently in order to run tests, or even build nits, you have to sudo make ; sudo make tests.
That means that pbuild can't run the regression tests as part of the build. Moving the sudo to the specific components in the makefiles means they can be built and run without elevation of the make.

not true. we don't need sudo to run tests. If you have previously run tests as sudo then you will either need to continue to use sudo, or blow away the output directory and start again as non-root.

palladia · 2016-09-14T22:48:56Z

Unix/codec/mof/parser/mof.qualifiers.h

+extern MI_QualifierDecl gQualifiers[];
+
+#endif /* _mof_qualifiers_h */
+


Both old and new have a large block enclosed by #if 0...#endif. What's different?

line endings. There are a lot of files with dos line endings interfering with compilation. I didn't do all of the line endings, but those that were preventing the build had to be changed.

palladia · 2016-09-14T22:50:27Z

Unix/common/MI.h

+#else
+#define MI_LINKAGE MI_EXPORT
+#endif
+MI_EXPORT MI_Result MI_MAIN_CALL MI_Application_InitializeV1(


I don't see MI_LINKAGE used anywhere. Why define these?

niroyb · 2016-09-15T05:06:37Z

Unix/disp/agentmgr.c

    trace_AgentLaunch_Failed(scs(agentProgram), errno);
    _exit(1);
-    return -1;  /* never get here */
+    // return -1;  /* never get here */


This is probably here to tame a compiler that expects a return statement.

Do we know which compiler? If so we can ifdef it.

if we successfully pbuild without this line I would suggest just deleting it instead of commenting it out or #ifdef-ing

niroyb · 2016-09-15T05:10:03Z

Unix/indication/indimgr/classlist.c


    size_t i;
    WQL_SymbolEx symbols[WQL_MAX_SYMBOLS];
+    memset(&symbols[0], 0, sizeof(symbols));


symbols is equivalent to &symbols[0]

The memset is the point.

paulcallen

Remove the sudos from the config files and the rest looks fine

paulcallen · 2016-09-15T18:39:37Z

Unix/build.mak

 ifdef BUILD_TESTS
 tests:
-	( LD_LIBRARY_PATH=$(LIBDIR); export LD_LIBRARY_PATH; DYLD_LIBRARY_PATH=$(LIBDIR); export DYLD_LIBRARY_PATH; $(BINDIR)/nits -file:$(TMPDIR)/nitsargs.txt )
+	sudo sh -c "( LD_LIBRARY_PATH=$(LIBDIR); export LD_LIBRARY_PATH; DYLD_LIBRARY_PATH=$(LIBDIR); export DYLD_LIBRARY_PATH; $(BINDIR)/nits -file:$(TMPDIR)/nitsargs.txt )"


not true. we don't need sudo to run tests. If you have previously run tests as sudo then you will either need to continue to use sudo, or blow away the output directory and start again as non-root.

paulcallen · 2016-09-15T18:47:41Z

Unix/disp/agentmgr.c

    trace_AgentLaunch_Failed(scs(agentProgram), errno);
    _exit(1);
-    return -1;  /* never get here */
+    // return -1;  /* never get here */


if we successfully pbuild without this line I would suggest just deleting it instead of commenting it out or #ifdef-ing

Prior OS/X changes for SSL broke the Solaris builds

…ld_library_path and dyld_library_path set.

yakman2020 · 2016-09-20T15:34:38Z

Removed the sudos, fixed the mac CI issue (the server needs ld_library_path set) and rebased to georges latest changes.

…nd macos. (#70) * Fix builds on Solaris 10 platforms Prior OS/X changes for SSL broke the Solaris builds * Fixes for aix solaris hpux macos * fix for solaris * aix export libmi.so identifiers. provider use libmi * dangling commas are illegal and caught by the sun compiler * dos line endings making the solaris compiler sick * Remove dos line endings from test_lex.cpp * Removed the sudos * Fixed macos regress problem. Since the server uses libmi.so it needs ld_library_path and dyld_library_path set. * Fixed syntax error which causes problems with sun

palladia reviewed Sep 14, 2016

View reviewed changes

niroyb reviewed Sep 15, 2016

View reviewed changes

paulcallen suggested changes Sep 15, 2016

View reviewed changes

jeffaco and others added 10 commits September 15, 2016 18:01

Fix builds on Solaris 10 platforms

f874f60

Prior OS/X changes for SSL broke the Solaris builds

Fixes for aix solaris hpux macos

1ba2416

fix for solaris

c48fb5d

aix export libmi.so identifiers. provider use libmi

5007dd9

dangling commas are illegal and caught by the sun compiler

6d0f651

dos line endings making the solaris compiler sick

a97fa14

Remove dos line endings from test_lex.cpp

db0056a

Removed the sudos

9c6ec43

Fixed macos regress problem. Since the server uses libmi.so it needs …

615b1c7

…ld_library_path and dyld_library_path set.

Fixed syntax error which causes problems with sun

9aaaed4

yakman2020 force-pushed the wsman-client-pbuild branch from a2a4c48 to 615b1c7 Compare September 20, 2016 15:29

paulcallen approved these changes Sep 20, 2016

View reviewed changes

yakman2020 merged commit 3276834 into wsman-client-feature Sep 20, 2016

		extern MI_QualifierDecl gQualifiers[];

		#endif /* _mof_qualifiers_h */

		END_EXTERNC

Changes to wsman-client-feautre to enable build on aix,hpux,solaris and macos. #70

Changes to wsman-client-feautre to enable build on aix,hpux,solaris and macos. #70

Uh oh!

Conversation

yakman2020 commented Sep 14, 2016

Uh oh!

palladia commented Sep 14, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paulcallen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yakman2020 commented Sep 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants