George/enumerate2 #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@paulcallen, please review. |
paulcallen
approved these changes
Oct 14, 2016
Contributor
paulcallen
left a comment
There was a problem hiding this comment.
fix the unittest and it looks good
| string expect; | ||
| NitsCompare(InhaleTestFile("TestOMICLI27.txt", expect), true, MI_T("Inhale failure")); | ||
| NitsCompareString(out.c_str(), expect.c_str(), MI_T("Output mismatch")); | ||
| NitsCompare(InhaleTestFile("TestOMICLI26.txt", expect), true, MI_T("Inhale failure")); |
Contributor
There was a problem hiding this comment.
there is no point inhaling if you are not comparing! I thing you should be using your WordCount
Contributor
Author
There was a problem hiding this comment.
I think this one is OK. It's an invoke (iv) test, and we're asking it to spell "123".
b4f1131 to
2731bd0
Compare
9d0e090 to
8575d93
Compare
Yash-Khatri
added a commit
that referenced
this pull request
Mar 12, 2024
* Fixes socket permission for handle sig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle multiple items in each response.