Fix PE Reader Pattern #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PE reader reads into a buffer and then slices that buffer in a loop while parsing. The previous code produced mutable references to slices of the buffer in a loop. This works fine in debug mode but breaks in release mode likely due to optimizer behavior. This is fixed by removing the unnecessary mutable references and switching to immutable references.
beaubelgrave
approved these changes
Oct 20, 2025
|
I think the issue is that there are multiple mutable borrows and the optimizer assumes that nothing will change the data except for the current mutable borrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PE reader reads into a buffer and then slices that buffer in a loop while parsing. The previous code produced mutable references to slices of the buffer in a loop. This works fine in debug mode but breaks in release mode likely due to optimizer behavior.
This is fixed by removing the unnecessary mutable references and switching to immutable references.