chore: update @middy/cloudformation-router type test
#1442
Merged
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrazauskas <[email protected]>
510cdee to
677064f
Compare
jonathanstumm
approved these changes
Aug 24, 2025
willfarrell
approved these changes
Aug 24, 2025
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR updates
@middy/cloudformation-routertype test. It has a commented out line which importsCloudFormationCustomResourceHandlertype.I searched GitHub for usage examples and updated the test to use the
CloudFormationCustomResourceHandlertype instead ofany.Currently
createLambdaHandlerin the following line hasanytype. After this change it gets typed asCloudFormationCustomResourceHandler. The type test ensures it is assignable to the type ofhandler.middy/packages/cloudformation-router/index.test-d.ts
Line 21 in f4090b0
Todo List: