Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add failing test for findOne by entity with composite PK's & FK's #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

chore: add failing test for findOne by entity with composite PK's & FK's #5675

wants to merge 12 commits into from

Conversation

@russell-dot-js
Copy link
Contributor

@russell-dot-js russell-dot-js commented Jun 4, 2024 •
edited
Loading

results in mismatch between selected fields and value tuples, see this comment

@codecov
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (d5d7f38) to head (d350515).

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #5675    +/-   ##
========================================
  Coverage   99.74%   99.74%            
========================================
  Files         261      261            
  Lines       18121    18121            
  Branches     3888     4436   +548     
========================================
  Hits        18074    18074            
  Misses         47       47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@B4nan
Copy link
Member

B4nan commented Jun 5, 2024

can you adjust the PR title and description? it should reflect what the PR is doing since it dictates the commit message

@russell-dot-js
Copy link
Contributor Author

can you adjust the PR title and description? it should reflect what the PR is doing since it dictates the commit message

sorry, having a little bit of a brain fart. the PR title says I added a failing test for findOne, code looks like it's doing that, what am I missing

@B4nan
Copy link
Member

B4nan commented Jun 7, 2024

oh its just a repro, i though its like the other PR where you also had the exact same PR title, tests were green and it was because you actually fixed that already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russell-dot-js @B4nan