added printing status and tests for it #1168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late reply and thanks for the PR! I am a bit hesitant to merge it though. There is so many ways in which |
|
That makes sense, but the code already has just an unused variable |
|
I think most people prefer to print status, because without printing it one doesn't even know how many iterations of training have been done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing extension had default print_status=True without the ability to change it, I'm just adding it as a an argument.
Also added tests to a new
test_printing.py, I found there was a printing test intest_progressbarbut that felt more like a integration test than a unit test for something so simple as the print_status argument.