This repository was archived by the owner on Aug 9, 2023. It is now read-only.
avoid race condition which results in duplicate book entities on the enchanting table #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
also tried to PR https://github.com/minetest-mods/enchanting, but that's archived and locked for some reason? |
SmallJoker
reviewed
Jul 21, 2022
SmallJoker
approved these changes
Jul 22, 2022
Member
SmallJoker
left a comment
There was a problem hiding this comment.
Works. Will merge in a few days unless there are objections.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because of a race condition, the check for whether to regenerate a book entity can happen while the entity is unloaded, resulting in multiple entities per enchanting table. on the your-land server, i've found at least one enchanting table with 391 (!) book entities over the same table.
the fix for this is to not save the entity w/ the mapblock, and to instead re-generate it every time the block is loaded.