DI Container Improvements #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is refactoring the App class to start using the DI container for the services and also to store some configurations like important paths for the application, like the base path and the configuration path. Later we can use it to store other paths like storage/log paths, etc.
This is also deprecating the
servicesandloadedServiceslogic in App, replacing that to use the DI container instead.This also adds a test case for the new configuration folder/files.
Why
This is an initial and simple implementation to start using the DI container, in the future, everything should be refactored to be using the DI container. This is just the beginning of the needed changes.