Thanks to visit codestin.com
Credit goes to github.com

Skip to content

register multiple commands #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WendellAdriel merged 2 commits into from
Jun 13, 2023
Merged

register multiple commands #98

WendellAdriel merged 2 commits into from
Jun 13, 2023

Conversation

@m47e
Copy link
Collaborator

@m47e m47e commented Jun 10, 2023

This is a method named registerCommands that allows to register many commands instead of one command.

 /**
     * @param array<string, callable> $commands
     * @return void
     */
    public function registerCommands(array $commands): void
    {
        foreach ($commands as $name => $callable) {
            $this->registerCommand($name, $callable);
        }
    }

WendellAdriel
WendellAdriel requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@WendellAdriel WendellAdriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some checks are failing, but besides that, I think that's all good! 💪

@m47e
Copy link
Collaborator Author

m47e commented Jun 12, 2023 •
edited
Loading

Yeah you're right i forgot to lint using pint

@erikaheidi erikaheidi requested a review from WendellAdriel June 13, 2023 06:16
@WendellAdriel WendellAdriel merged commit 07718a9 into minicli:main Jun 13, 2023
@WendellAdriel
Copy link
Member

WendellAdriel commented Jun 13, 2023

Thanks for the contribution @tal7aouy 🔥

@m47e
Copy link
Collaborator Author

m47e commented Jun 13, 2023

Happy to contribute 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikaheidi erikaheidi erikaheidi approved these changes

@WendellAdriel WendellAdriel WendellAdriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Minicli Development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m47e @WendellAdriel @erikaheidi