Fix insecure logging of HTTP username and password for Git repo URL #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m Git repo HTTP URLs to INFO log. This commit removes the repo URL from the affected log statement. * Removed GetRepoURL() function call from exporter cloning step.
Contributor
Author
|
Hi @eduardev - when you have a moment, could you give this a review? |
fabiomsouto
approved these changes
Jun 4, 2020
Contributor
fabiomsouto
left a comment
There was a problem hiding this comment.
Hey @thecosmicfrog,
I'll merge this in, it's a reasonable concern and the fix is proper.
Contributor
|
Thanks for this! |
Contributor
Author
|
Wonderful! Thanks @fabiomsouto! |
Contributor
Author
|
@fabiomsouto Quick question - will you be building a v0.2.3 Docker image with this change? I'd like to roll this out today with INFO logging enabled (now that it's safe for us) if it's possible :) Thanks! |
Contributor
|
I've tagged it a couple of minutes ago, should be there now. Enjoy! |
Contributor
Author
|
@fabiomsouto Brilliant - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation logs HTTP Basic Auth username and password from Git repo HTTP URLs to INFO log. This commit removes the repo URL from the affected log statement.
Example: