Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jiuker
Copy link
Contributor

@jiuker jiuker commented Jun 7, 2024

fix: mc mirror got zero exit code when access denied

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

fix: mc mirror got zero exit code when access denied

Motivation and Context

How to test this PR?

root@DESKTOP-QPDA04R:/mnt/c/workspace/go/src/mc# ./mc mirror play/test gcs/test
 0 B / ? ┃░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░▓┃
mc: <ERROR> Failed to perform mirroring Access denied.
 0 B / ? ┃░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░▓┃ 1s
root@DESKTOP-QPDA04R:/mnt/c/workspace/go/src/mc# echo $?
1   <-------------before is 0 
root@DESKTOP-QPDA04R:/mnt/c/workspace/go/src/mc# 

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

fix: mc mirror got zero exit code when access denied
@shtripat
Copy link
Contributor

shtripat commented Jun 7, 2024

Any impact on other commands like mc find and mc diff due to the change?

@jiuker
Copy link
Contributor Author

jiuker commented Jun 7, 2024

Any impact on other commands like mc find and mc diff due to the change?

No, access denied can't retry.

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit e44a1c6 into minio:master Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants