-
Couldn't load subscription status.
- Fork 6.4k
xl: remove cleanupDir instead use Delete() #11880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
use a single call to remove directly at disk instead of doing recursively at network layer.
3d78828 to
873a7d0
Compare
Mint Automation
11880-873a7d0/mint-compress-encrypt-dist-erasure.sh.log:Deleting image on docker hub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but with one nit comment
Description
xl: remove cleanupDir instead use Delete()
Motivation and Context
use a single call to remove directly at disk
instead of doing recursively at the network layer.
How to test this PR?
Generate lots of failed requests such as PutObject()
with a slowReader{} and close the connection prematurely
before server times out, this starts the cleanup routine that
would be slow, then don't wait subsequently send more
requests and let them timeout as well.
The code change simply ensures that we use efficient calls
to delete the temporary folder upon client timeout.
Types of changes
Checklist:
commit-idorPR #here)