heal/batch: Fix missing redirection to the first node #20642
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual heal can return XMinioHealInvalidClientToken if the manual healing is started in the first node and the next mc call to get the heal status is landed to another node. The reason is that redirection based on the token id is not able to redirect requests to the first node due to a typo. This also affects batch cancel command, if the batch is being done in the first node, the user will never be able to cancel it due to the same bug.
harshavardhana
approved these changes
Nov 13, 2024
vadmeste
added a commit
to vadmeste/minio
that referenced
this pull request
Dec 12, 2024
Manual heal can return XMinioHealInvalidClientToken if the manual healing is started in the first node, and the next mc call to get the heal status is landed on another node. The reason is that redirection based on the token ID is not able to redirect requests to the first node due to a typo. This also affects the batch cancel command if the batch is being done in the first node, the user will never be able to cancel it due to the same bug.
vadmeste
added a commit
to vadmeste/minio
that referenced
this pull request
Dec 18, 2024
Manual heal can return XMinioHealInvalidClientToken if the manual healing is started in the first node, and the next mc call to get the heal status is landed on another node. The reason is that redirection based on the token ID is not able to redirect requests to the first node due to a typo. This also affects the batch cancel command if the batch is being done in the first node, the user will never be able to cancel it due to the same bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Manual heal can return XMinioHealInvalidClientToken if the manual healing is started in the first node and the next mc call to get the heal status is landed in another node. The reason is that redirection based on the token id is not able to redirect requests to the first node due to a typo in the code.
This also affects batch cancel command, if the batch is being done in the first node, the user will never be able to cancel it due to the same bug.
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)