heal: Better reporting to mc with dangling/timeout errors #20690
+35
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code assigns corrupted state to a drive for any unexpected error, which is confusing for users. This change will make sure to assign corrupted state only for corrupted parts or xl.meta. Use unknown state with a explanation for any unexpected error, like canceled, deadline errors, drive timeout, ... Also make sure to return the bucket/object name when the object is not found or marked not found by the heal dangling code.
klauspost
approved these changes
Nov 26, 2024
harshavardhana
approved these changes
Nov 26, 2024
harshavardhana
pushed a commit
that referenced
this pull request
Mar 17, 2025
The code assigns corrupted state to a drive for any unexpected error, which is confusing for users. This change will make sure to assign corrupted state only for corrupted parts or xl.meta. Use unknown state with a explanation for any unexpected error, like canceled, deadline errors, drive timeout, ... Also make sure to return the bucket/object name when the object is not found or marked not found by the heal dangling code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
The code assigns corrupted state to a drive for any unexpected error,
which is confusing for users. This change will make sure to assign
corrupted state only for corrupted parts or xl.meta. Use unknown state
with a explanation for any unexpected error, like canceled, deadline
errors, drive timeout, ...
Also make sure to return the bucket/object name when the object
is not found or marked not found by the heal dangling code.
Motivation and Context
Better reporting to the hidden mc admin heal command.
How to test this PR?
Fake a dangling object and run
mc admin heal -r ALIASwith latest mc masterTypes of changes
Checklist:
commit-idorPR #here)