if z.SinglePool() {
		idx := z.getAvailablePoolIdx(ctx, bucket, object, data.Size())
		if idx < 0 {
			return ObjectInfo{}, toObjectErr(errDiskFull)
		}
		return z.serverPools[0].PutObject(ctx, bucket, object, data, opts)
	}

@leoliulei what happens to existing versions?

if z.SinglePool() {
		idx := z.getAvailablePoolIdx(ctx, bucket, object, data.Size())
		if idx < 0 {
			return ObjectInfo{}, toObjectErr(errDiskFull)
		}
		return z.serverPools[0].PutObject(ctx, bucket, object, data, opts)
	}

@leoliulei what happens to existing versions?

Put object will generate a temp object, This commit will also check whether there is available space when it encounters an existing version.

The simplest way is indeed this, but we also fixed a BUG in the case of multiple pools, that is, multiple versions of files will not be restricted, just to unify the entry. @leoliulei @harshavardhana

The simplest way is indeed this, but we also fixed a BUG in the case of multiple pools, that is, multiple versions of files will not be restricted, just to unify the entry. @leoliulei @harshavardhana

Yes, I agree with this.

@jiuker I think this is a bit expensive to issue a GetObjectInfo for every Put call.

Probably a better way is to return the appropriate no space error when any drive returns errDiskFull

But if the object are Decommissioned or Rebalanced, the

pinfo, _, err := z.getPoolInfoExistingWithOpts(ctx, bucket, object, ObjectOptions{
		SkipDecommissioned: true,
		SkipRebalancing:    true,
	})

will show the the exist object real pool index. Right @vadmeste

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 15 days if no further activity occurs. Thank you for your contributions.